Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mutating schedulingGates in the Pod template for suspended Jobs #115940

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Allow mutating schedulingGates in the Pod template for suspended Jobs #115940

merged 1 commit into from
Feb 28, 2023

Conversation

ahg-g
Copy link
Member

@ahg-g ahg-g commented Feb 21, 2023 •
edited
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

Allow mutating schedulingGates in the Pod template of suspended Jobs.

Which issue(s) this PR fixes:

Part of #104714

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Pod template `schedulingGates` are now mutable for Jobs that are suspended and have never been started

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[KEP]: https://github.com/kubernetes/enhancements/tree/master/keps/sig-scheduling/2926-job-mutable-scheduling-directives

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 21, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 21, 2023
@ahg-g
Copy link
Member Author

ahg-g commented Feb 21, 2023

/assign @liggitt

@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Feb 21, 2023
@sftim
Copy link
Contributor

sftim commented Feb 21, 2023 

Pod template `schedulingGates` are now mutable for Jobs that are suspended and have never been started.

Changelog suggestion
or as a diff:

-Pod template SchedulingGates are now mutable for jobs that are suspended and have never been started
+Pod template `schedulingGates` are now mutable for Jobs that are suspended and have never been started.

@sftim
Copy link
Contributor

sftim commented Feb 21, 2023

BTW we seem to link to the GitHub issue for KEPs as a convention. I'm not sure if that's what's expected but it's what I see.

@liggitt liggitt added the api-review Categorizes an issue or PR as actively needing an API review. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 24, 2023
@ahg-g ahg-g mentioned this pull request Feb 28, 2023
Closed
8 tasks
@liggitt
Copy link
Member

liggitt commented Feb 28, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 53ec47a006553596ab1a8471e6008970e4aead9b

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit e519921 into kubernetes:master Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@liggitt liggitt

Labels
api-review Categorizes an issue or PR as actively needing an API review. approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
API Reviews
Status: API review completed, 1.27
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.
4 participants
@ahg-g @k8s-ci-robot @sftim @liggitt