-
Notifications
You must be signed in to change notification settings - Fork 40.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WinProxy] Adding additional validations to queried endpoint list iteration. #116749
[WinProxy] Adding additional validations to queried endpoint list iteration. #116749
Conversation
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @princepereira. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@princepereira: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: princepereira, sbangari The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 1318d0a7998efa1fb4021ffb5ab173133551c667
|
…f-#116749-upstream-release-1.26 Automated cherry pick of #116749: Adding additional validations to queried endpoint
…f-#116749-upstream-release-1.25 Automated cherry pick of #116749: Adding additional validations to queried endpoint
…f-#116749-upstream-release-1.27 Automated cherry pick of #116749: Adding additional validations to queried endpoint
What type of PR is this?
/kind cleanup
/kind regression
What this PR does / why we need it:
This PR adds additional validation to check if the endpoints queried from the nodes are with IpConfigurations.
Which issue(s) this PR fixes:
If the queried endpoints are with out any IpConfigurations, then it will end up in index out of bound exceptions which can create continuous crashing of kubeproxy.
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/sig windows
/sig network
/test pull-kubernetes-e2e-capz-windows-containerd-1-24