Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a bug where the AttachedVolume is not printed correctly in the log #117907

Merged
merged 1 commit into from
May 11, 2023
Merged

Fix a bug where the AttachedVolume is not printed correctly in the log #117907

merged 1 commit into from
May 11, 2023

Conversation

SataQiu
Copy link
Member

@SataQiu SataQiu commented May 10, 2023 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

cache.AttachedVolume does NOT implement fmt.Stringer interface, the String() method of embedded field operationexecutor.AttachedVolume will be called wrongly in log printing.

Which issue(s) this PR fixes:

Ref #115950

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 10, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 10, 2023
@SataQiu SataQiu mentioned this pull request May 10, 2023
Merged
@SataQiu
Copy link
Member Author

SataQiu commented May 10, 2023

/assign @thockin

@SataQiu
Copy link
Member Author

SataQiu commented May 11, 2023

Since kubernetes-sigs/logtools#17 has been merged, waiting for logtools version bump.

@SataQiu
Copy link
Member Author

SataQiu commented May 11, 2023

/cc @pohly

@k8s-ci-robot k8s-ci-robot requested a review from pohly May 11, 2023 02:58
thockin
thockin reviewed May 11, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want the whole object printed in all these places or just the name/namespace (kobj)

@SataQiu SataQiu force-pushed the fix-controller-log-20230510 branch from 0efd47a to 3fa55d4 Compare May 11, 2023 14:04
@SataQiu
Copy link
Member Author

SataQiu commented May 11, 2023

Do we really want the whole object printed in all these places or just the name/namespace (kobj)

Is it ok to log the key information(node and volumeName) about AttachedVolume here?
Since it is a reconciler, this is reasonable.

@humblec
Copy link
Contributor

humblec commented May 11, 2023

cc @jsafrane @msau42

thockin
thockin reviewed May 11, 2023
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 78359c4de748c30e973a59b461744efb8f951f9f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SataQiu, thockin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 87af78d into kubernetes:master May 11, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thockin thockin thockin left review comments

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@pohly pohly Awaiting requested review from pohly

Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
4 participants
@SataQiu @k8s-ci-robot @humblec @thockin