Switch to e2 machine types #118626
Merged
Switch to e2 machine types #118626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
/test pull-kubernetes-node-e2e-containerd-ec2 |
k8s-ci-robot
added
area/provider/gcp
upodroid
force-pushed
the
use-e2-instance-types
branch
from
0f545d5 to
be292ba
Compare
upodroid
commented
Jun 12, 2023
| @@ -43,9 +40,6 @@ function get-master-size { | |||
| if [[ "$(get-num-nodes)" -gt "500" ]]; then | |||
| suggested_master_size=32 | |||
| fi | |||
| if [[ "$(get-num-nodes)" -gt "2000" ]]; then | |||
There was a problem hiding this comment.
I'm assuming the control plane has been optimised after this change: #95947
|
/test pull-kubernetes-node-e2e-containerd-ec2 |
|
/cc |
|
/test |
|
@tzneal: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: bbbb1a1054324b251830ceca3954415a11341c9c
|
k8s-ci-robot
removed
the
needs-rebase
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, upodroid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced Jan 4, 2024
This was referenced Jan 12, 2024
p0lyn0mial
added a commit
to p0lyn0mial/test-infra
that referenced
this pull request
Jan 16, 2024
At the moment the tests fail with: ERROR: (gcloud.compute.instances.create) Could not fetch resource: - The selected machine type (n1-standard-32) is not compatible with CPU platform icelake Failed to create master instance due to non-retryable error Possibly caused by kubernetes/kubernetes#118626 https://cloud.google.com/compute/docs/general-purpose-machines#n2_series
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @dims
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
It is "discouraged" to use n1 as they are based on older architectures and e2 machine type is cheaper with the better CPU options.
I also need a PR to test AWS Node e2e tests.
Which issue(s) this PR fixes:
Fixes #116114
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: