Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: update swap warning for v1.28 change #120198

Merged
merged 1 commit into from
Aug 29, 2023
Merged

kubeadm: update swap warning for v1.28 change #120198

merged 1 commit into from
Aug 29, 2023

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Aug 28, 2023 •
edited
Loading

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

We have mentioned the steps to enable Swap with kubeadm in the blog: https://kubernetes.io/blog/2023/08/24/swap-linux-beta/#set-up-a-kubernetes-cluster-that-uses-swap-enabled-nodes.

  • A special note here is that Note that NodeSwap is supported for cgroup v2 only. For Kubernetes v1.28, using swap along with cgroup v1 is no longer supported.

Since 1.28, the FG is beta but disabled by default. I prefer to keep the warning and update it accordingly.

Which issue(s) this PR fixes:

xref kubernetes/kubeadm#2563

Special notes for your reviewer:

Does this PR introduce a user-facing change?

kubeadm: updated warning message when swap space is detected. When swap is active on Linux, kubeadm explains that swap is supported for cgroup v2 only and is beta but disabled by default.

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Aug 28, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Aug 28, 2023

/cc @sftim @neolit123 @iholder101

@k8s-ci-robot k8s-ci-robot added area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Aug 28, 2023
@k8s-ci-robot k8s-ci-robot requested a review from chendave August 28, 2023 03:44
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
@pacoxu pacoxu mentioned this pull request Aug 28, 2023
Open
neolit123
neolit123 reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

cmd/kubeadm/app/preflight/checks.go Outdated
@@ -653,7 +653,7 @@ func (swc SwapCheck) Check() (warnings, errorList []error) {
}

if len(buf) > 1 {
return []error{errors.New("swap is enabled; production deployments should disable swap unless testing the NodeSwap feature gate of the kubelet")}, nil
return []error{errors.New("swap is supported for cgroup v2 only; the NodeSwap feature gate of the kubelet is beta but disabled by default, and better keep it off")}, nil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return []error{errors.New("swap is supported for cgroup v2 only; the NodeSwap feature gate of the kubelet is beta but disabled by default, and better keep it off")}, nil
return []error{errors.New("swap is supported for cgroup v2 only; the NodeSwap feature gate of the kubelet is beta but disabled by default")}, nil
i think we can just say this part and let the user decide

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls let this pr hold for an while to wait for @pacoxu to address this comment.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chendave. Updated.

@iholder101
Copy link
Contributor

Thanks @pacoxu!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e0a0657ad15e9c602ef5c8f7cfe9c25954db6e1b

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2023
@chendave
Copy link
Member

/test pull-kubernetes-verify-strict-lint

not required, just see is there any suggestion for the lint job.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iholder101, neolit123, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

neolit123
neolit123 reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 28, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Aug 28, 2023

/test pull-kubernetes-e2e-gce

@sftim
Copy link
Contributor

sftim commented Aug 28, 2023

Is this change visible to people who use Kubernetes? If it is, we should add a changelog entry.

@chendave
Copy link
Member

Is this change visible to people who use Kubernetes? If it is, we should add a changelog entry.

this just update the error msg, no behavior change I think.

/lgtm
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a024d8c8b6487024f23aa07efb037fe714b75637

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Aug 29, 2023
@pacoxu
Copy link
Member Author

pacoxu commented Aug 29, 2023

Is this change visible to people who use Kubernetes? If it is, we should add a changelog entry.

this just update the error msg, no behavior change I think.

Yes. A release note may help(but just a warning message update is a tiny changelog.)

@chendave
Copy link
Member

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 29, 2023
@k8s-ci-robot k8s-ci-robot merged commit 34b85c5 into kubernetes:master Aug 29, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Aug 29, 2023
@sftim
Copy link
Contributor

sftim commented Aug 29, 2023

Changelog suggestion

kubeadm: updated warning message when swap space is detected. When swap is active on Linux, kubeadm explains that swap is supported for cgroup v2 only and is beta but disabled by default.

@pacoxu
Copy link
Member Author

pacoxu commented Aug 30, 2023

Thanks @sftim. Updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@iholder101 iholder101 iholder101 approved these changes

@sftim sftim Awaiting requested review from sftim

@chendave chendave Awaiting requested review from chendave

Assignees

@chendave chendave

@iholder101 iholder101

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
6 participants
@pacoxu @k8s-ci-robot @iholder101 @chendave @sftim @neolit123