Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check --show-events in kubectl describe pvc #120380

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Check --show-events in kubectl describe pvc #120380

merged 3 commits into from
Sep 18, 2023

Conversation

MaGaroo
Copy link
Contributor

@MaGaroo MaGaroo commented Sep 2, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

There is a flag --show-events in kubectl describe subcommand. In the current master branch, the PersistentVolumeClaimDescriber didn't take that flag into account. This PR is a small change to do so.

Which issue(s) this PR fixes:

There's not an issue related to this PR.

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Kubectl will not print events if --show-events=false argument is passed to describe PVC subcommand.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 2, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @MaGaroo!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 2, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @MaGaroo. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 2, 2023
@MaGaroo MaGaroo changed the title Check --show-events arg before fetching events Check --show-events in kubectl describe pvc Sep 2, 2023
@krmayankk
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2023
@krmayankk
Copy link

looks reasonable to me
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 948607de1264b5f0e5d0d0a8bccc861239308c69

@krmayankk
Copy link

@kubernetes/sig-cli-leads for review

@MaGaroo MaGaroo force-pushed the describe-pvc-consider-show-events branch from 6fc6ece to 8517e4e Compare September 15, 2023 09:26
@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 15, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 15, 2023
@soltysh
Copy link
Contributor

soltysh commented Sep 15, 2023

/triage accepted
/priority backlog
/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 15, 2023
soltysh
soltysh approved these changes Sep 15, 2023
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 15, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6a93094214c57823af00dfd099105675073f29bd

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaGaroo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2023
@MaGaroo
Copy link
Contributor Author

MaGaroo commented Sep 16, 2023

/retest-required

@pacoxu
Copy link
Member

pacoxu commented Sep 18, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit a919079 into kubernetes:master Sep 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.29 milestone Sep 18, 2023
Sharpz7 pushed a commit to Sharpz7/kubernetes that referenced this pull request Oct 27, 2023
@MaGaroo @Sharpz7
Check --show-events in kubectl describe pvc (kubernetes#120380)
7161650 
* Check --show-events arg before fetching events

* Remove unnecessary else statement

* Add test for false show events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

@krmayankk krmayankk Awaiting requested review from krmayankk

Assignees

@soltysh soltysh

@krmayankk krmayankk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.29
Development

Successfully merging this pull request may close these issues.
5 participants
@MaGaroo @k8s-ci-robot @krmayankk @soltysh @pacoxu