Introduce the job_finished_indexes_total metric #121292

mimowo · 2023-10-17T13:32:51Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

Implement metrics proposed in the JobBackoffLimitPerIndex feature KEP

Which issue(s) this PR fixes:

Part of: kubernetes/enhancements#3850

Special notes for your reviewer:

Wondering about moving the tests from integration to unit.

Does this PR introduce a user-facing change?

Introduce the job_finished_indexes_total metric for BackoffLimitPerIndex feature

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/3850-backoff-limits-per-index-for-indexed-jobs

k8s-ci-robot · 2023-10-17T13:33:01Z

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mimowo · 2023-10-17T13:33:36Z

/sig apps

mimowo · 2023-10-18T16:04:04Z

/assign @alculquicondor

alculquicondor · 2023-10-18T16:49:21Z

Is the description stale?

mimowo · 2023-10-19T12:57:19Z

test/integration/job/job_test.go

I've added the tests as integration, because this is what we did so far for most features, however, with the recent issues with test timeouts for integration I'm thinking about moving them to unit tests. WDYT @alculquicondor ?

Can you just add checks to the existing tests?

I think I can, let me try

pkg/controller/job/metrics/metrics.go

alculquicondor · 2023-10-19T19:16:24Z

/hold
to consolidate the integration tests

mimowo · 2023-10-20T14:02:06Z

/retest
Unrelated failure

alculquicondor

/lgtm
/approve

k8s-ci-robot · 2023-10-20T18:28:28Z

LGTM label has been added.

Git tree hash: 18ea0443a79e527281fb61ef3462afbb47af4578

k8s-ci-robot · 2023-10-20T18:28:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~pkg/controller/job/OWNERS~~ [alculquicondor]
~~test/integration/job/OWNERS~~ [alculquicondor]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alculquicondor · 2023-10-20T18:32:32Z

/hold cancel

alculquicondor · 2023-10-20T19:56:58Z

/retest
flaky #120080

k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Oct 17, 2023

k8s-ci-robot requested review from krmayankk and smarterclayton October 17, 2023 13:33

k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 17, 2023

mimowo force-pushed the backoff-limit-per-index-metrics branch 2 times, most recently from f68a548 to e585cb8 Compare October 18, 2023 16:03

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2023

mimowo changed the title ~~WIP: Introduce the job_finished_indexes_total metric~~ Introduce the job_finished_indexes_total metric Oct 18, 2023

k8s-ci-robot added area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 18, 2023

k8s-ci-robot assigned alculquicondor Oct 18, 2023

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2023

mimowo force-pushed the backoff-limit-per-index-metrics branch from e585cb8 to 8ca5d11 Compare October 19, 2023 09:17

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2023

mimowo force-pushed the backoff-limit-per-index-metrics branch 2 times, most recently from e28aa79 to 5c1eb29 Compare October 19, 2023 10:48

mimowo force-pushed the backoff-limit-per-index-metrics branch 2 times, most recently from aa0770f to f28a2a8 Compare October 19, 2023 11:20

mimowo mentioned this pull request Oct 19, 2023

Graduate BackoffLimitPerIndex to Beta #121356

Merged

6 tasks

mimowo commented Oct 19, 2023

View reviewed changes

jensentanlo mentioned this pull request Oct 19, 2023

Backoff Limit Per Index For Indexed Jobs kubernetes/enhancements#3850

Closed

12 tasks

alculquicondor reviewed Oct 19, 2023

View reviewed changes

pkg/controller/job/metrics/metrics.go Outdated Show resolved Hide resolved

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 19, 2023

mimowo force-pushed the backoff-limit-per-index-metrics branch from f28a2a8 to d1fcd84 Compare October 20, 2023 13:17

Introduce the job_finished_indexes_total metric

b0d04d9

mimowo force-pushed the backoff-limit-per-index-metrics branch from d1fcd84 to b0d04d9 Compare October 20, 2023 13:19

alculquicondor reviewed Oct 20, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 20, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2023

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2023

alculquicondor mentioned this pull request Oct 20, 2023

feat: add job_pods_creation_total metric for PodReplacementPolicy #121312

Closed

k8s-ci-robot merged commit 1fc3d10 into kubernetes:master Oct 20, 2023

k8s-ci-robot added this to the v1.29 milestone Oct 20, 2023

mimowo deleted the backoff-limit-per-index-metrics branch November 29, 2023 15:00

Introduce the job_finished_indexes_total metric #121292

Introduce the job_finished_indexes_total metric #121292

Uh oh!

Conversation

mimowo commented Oct 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Uh oh!

k8s-ci-robot commented Oct 17, 2023

Uh oh!

mimowo commented Oct 17, 2023

Uh oh!

mimowo commented Oct 18, 2023

Uh oh!

alculquicondor commented Oct 18, 2023

Uh oh!

mimowo Oct 19, 2023

Choose a reason for hiding this comment

Uh oh!

alculquicondor Oct 19, 2023

Choose a reason for hiding this comment

Uh oh!

mimowo Oct 20, 2023

Choose a reason for hiding this comment

Uh oh!

mimowo Oct 20, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alculquicondor commented Oct 19, 2023

Uh oh!

mimowo commented Oct 20, 2023

Uh oh!

alculquicondor left a comment

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Oct 20, 2023

Uh oh!

k8s-ci-robot commented Oct 20, 2023

Uh oh!

alculquicondor commented Oct 20, 2023

Uh oh!

alculquicondor commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mimowo commented Oct 17, 2023 •

edited

Loading