Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #121881: Use golang library instead of mklink #121882

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Automated cherry pick of #121881: Use golang library instead of mklink #121882

merged 1 commit into from
Nov 15, 2023

Conversation

cji
Copy link
Member

@cji cji commented Nov 14, 2023 •
edited by k8s-ci-robot
Loading

Cherry pick of #121881 on release-1.28.

#121881: Use golang library instead of mklink

For details on the cherry pick process, see the cherry pick requests page.

NONE

@jsturtevant @cji
Use golang library instead of mklink
4a15ef2 
Signed-off-by: James Sturtevant <jstur@microsoft.com>
@k8s-ci-robot k8s-ci-robot added this to the v1.28 milestone Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 14, 2023
@cji cji mentioned this pull request Nov 14, 2023
Closed
@jsafrane
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2023
@marosset
Copy link
Contributor

/triage accepted
/priority critical-urgent
/sig windows
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a596fa131e52b41e1655d9432e6bd958b2c95db4

@marosset
Copy link
Contributor

/test pull-kubernetes-e2e-capz-windows-1-28

3 similar comments
@cji
Copy link
Member Author

cji commented Nov 14, 2023

/test pull-kubernetes-e2e-capz-windows-1-28

@marosset
Copy link
Contributor

/test pull-kubernetes-e2e-capz-windows-1-28

@marosset
Copy link
Contributor

/test pull-kubernetes-e2e-capz-windows-1-28

@marosset
Copy link
Contributor

I think the quay.io outage that was causing issues with the test cluster bring-up has been resolved
/test pull-kubernetes-e2e-capz-windows-1-28

@jsafrane
Copy link
Member

/test pull-kubernetes-e2e-capz-windows-1-28

xmudrii
xmudrii approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For RelEng:
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cji, jsafrane, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii xmudrii added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit ceeb198 into kubernetes:release-1.28 Nov 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@jingxu97 jingxu97 Awaiting requested review from jingxu97

Assignees

@marosset marosset

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
v1.28
Development

Successfully merging this pull request may close these issues.
6 participants
@cji @jsafrane @marosset @k8s-ci-robot @xmudrii @jsturtevant