fix: handle socket file detection on Windows

[fakecore]

Update socket file detection logic to use os.Stat as per upstream Go fix for golang/go#33357. This resolves the issue where socket files could not be properly identified on Windows systems.

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update to use os.Stat instead of os.Lstat when deleting the device-plugins socket file, rather than deleting all files in the /var/lib/kubelet/device-plugins/ directory.

Which issue(s) this PR fixes:

related issue: #97554
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[linux-foundation-easycla]

• ✅login: fakecore / (4060ee6)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

Welcome @fakecore!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @fakecore. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fakecore]

/check-required-labels

[cblecker]

/ok-to-test

[fakecore]

/retest

[hakman]

@fakecore I don't see commit golang/go@628b101 cherry-picked to any of the current Go release branches.
I think merging this PR should wait until Kubernetes is built using a Go version containing the above mentioned commit.

[ffromani]

@fakecore I don't see commit golang/go@628b101 cherry-picked to any of the current Go release branches. I think merging this PR should wait until Kubernetes is built using a Go version containing the above mentioned commit.

I agree. Looks like a nice fix, but we need to make sure the dependencies are satisfied. I'll check what's the best triage labeling for this kind of state. Holding meanwhile.

[ffromani]

/hold

per #123819 (comment)

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[fakecore]

hi all, I noticed current kubernets build version is go1.22.4
this patch release with go1.22.1
can we merge this ?

[fakecore]

/remove-lifecycle stale

[ffromani]

hi all, I noticed current kubernets build version is go1.22.4 this patch release with go1.22.1 can we merge this ?

I'd bump go.mod to 1.22.1 at least, or somehow require at least go 1.22.1 before to merge

[ffromani]

/priority backlog

[fakecore]

hi all, I noticed current kubernets build version is go1.22.4 this patch release with go1.22.1 can we merge this ?

I'd bump go.mod to 1.22.1 at least, or somehow require at least go 1.22.1 before to merge

Could we use the version specified in .go-version instead?

[ffromani]

hi all, I noticed current kubernets build version is go1.22.4 this patch release with go1.22.1 can we merge this ?

I'd bump go.mod to 1.22.1 at least, or somehow require at least go 1.22.1 before to merge

Could we use the version specified in .go-version instead?

right, forgot about this. I think it's fine? cc @cpanato to crosscheck

[ffromani]

/triage accepted

[ffromani]

/hold
/lgtm

AFAIU master branch is already on golang >= 1.22.4, so this seems safe to move forward

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d2971bddc1203367a5f70f64424c64ccac45da3b

[fakecore]

@ffromani Should I do anything to expedite the merging of this PR? It's been hanging there for a while.

[ffromani]

@ffromani Should I do anything to expedite the merging of this PR? It's been hanging there for a while.

we need approval review, tagging few ppl which can help @klueska @mrunalp @dchen1107

[fakecore]

@ffromani Should I do anything to expedite the merging of this PR? It's been hanging there for a while.

we need approval review, tagging few ppl which can help @klueska @mrunalp @dchen1107

I have no idea who the maintainer is for this node. Thanks for your help!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fakecore, mrunalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/kubelet/cm/OWNERS [mrunalp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ffromani]

/hold cancel

no longer relevant (xref: #123819 (comment))

[k8s-ci-robot]

@fakecore: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-kubernetes-integration	4060ee6	link	unknown	/test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.