Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote Filip as sig-apps approver #124414

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Promote Filip as sig-apps approver #124414

merged 1 commit into from
Apr 22, 2024

Conversation

soltysh
Copy link
Contributor

@soltysh soltysh commented Apr 19, 2024

What type of PR is this?

/kind cleanup
/sig apps

What this PR does / why we need it:

@atiratree has been very active participant in sig-apps over the past years. His main contributions has been:

and multiple code reviews and code changes in broad controller areas.

Special notes for your reviewer:

/assign @janetkuo @kow3ns
for sig-apps approval
/assign @dims
for top-level changes

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 19, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 19, 2024
@k8s-ci-robot k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 19, 2024
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2024
@soltysh
Copy link
Contributor Author

soltysh commented Apr 19, 2024

/triage accepted
/priority backlog
/hold
for reviews

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Apr 19, 2024
@soltysh
Copy link
Contributor Author

soltysh commented Apr 19, 2024

cc @atiratree

@kannon92
Copy link
Contributor

Yay!

janetkuo
janetkuo approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@janetkuo janetkuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 19, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: c093f33970e162a502e5efe235ecea64e4a82d6b

@dims
Copy link
Member

dims commented Apr 20, 2024

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, janetkuo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@atiratree
Copy link
Member

Thanks a lot everyone! 😁

@soltysh
Copy link
Contributor Author

soltysh commented Apr 22, 2024

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9c9a0e3 into kubernetes:master Apr 22, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone Apr 22, 2024
@soltysh soltysh deleted the filip_approver branch April 22, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@logicalhan logicalhan Awaiting requested review from logicalhan

Assignees

@dims dims

@janetkuo janetkuo

@kow3ns kow3ns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.
7 participants
@soltysh @kannon92 @k8s-ci-robot @dims @atiratree @janetkuo @kow3ns