Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch cni plugins from GitHub releases #129095

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

upodroid
Copy link
Member

@upodroid upodroid commented Dec 5, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fetch CNI plugins from GitHub releases instead of the k8s-artifacts-cni GCS bucket.

Which issue(s) this PR fixes:

Part of kubernetes/k8s.io#7584

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Dec 5, 2024
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.32 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.32.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Thu Dec 5 04:45:50 UTC 2024.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 5, 2024
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer December 5, 2024 10:33
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 5, 2024
@k8s-ci-robot k8s-ci-robot added area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 5, 2024
@upodroid
Copy link
Member Author

upodroid commented Dec 5, 2024

/sig k8s-infra
/triage accepted

@k8s-ci-robot k8s-ci-robot added sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 5, 2024
@ameukam
Copy link
Member

ameukam commented Dec 5, 2024

FYI @kubernetes/release-engineering

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Dec 5, 2024
@upodroid
Copy link
Member Author

upodroid commented Dec 5, 2024

/milestone v1.32

@k8s-ci-robot k8s-ci-robot added this to the v1.32 milestone Dec 5, 2024
@dims
Copy link
Member

dims commented Dec 5, 2024

/hold

@upodroid did you really mean 1.32? need this milestone to be applied by the release folks ( cc @fsmunoz )

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2024
@upodroid
Copy link
Member Author

upodroid commented Dec 9, 2024

did you really mean 1.32? need this milestone to be applied by the release folks ( cc @fsmunoz )

Yes, this change isn't user facing and doesn't affect tests.

@ameukam
Copy link
Member

ameukam commented Dec 17, 2024

@dims @SergeyKanzhelev PTAL for approval.

@dims
Copy link
Member

dims commented Dec 17, 2024

/approve
/lgtm

please feel free to remove hold when ready!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7dab64cdaff8e84cd7e06360b7b0fe0d30a3fd79

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, upodroid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@ameukam
Copy link
Member

ameukam commented Dec 18, 2024

/hold cancel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants