-
Notifications
You must be signed in to change notification settings - Fork 41.8k
disable in-place pod vertical scaling for swap enabled pods #130831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable in-place pod vertical scaling for swap enabled pods #130831
Conversation
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @ajaysundark. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cf222e4 to
60c1d1a
Compare
|
/ok-to-test |
60c1d1a to
a57c529
Compare
tallclair
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a couple little things
0384a3d to
d6f2bb2
Compare
d6f2bb2 to
a09cb22
Compare
|
/lgtm Thanks! |
|
LGTM label has been added. Git tree hash: 3c51acf35a331192643d00c36aac4eaa6a843dc7
|
|
/test pull-kubernetes-node-kubelet-serial-podresize |
|
/hold |
|
/retest |
|
/unhold |
|
@ajaysundark: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ajaysundark, tallclair, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Unrelated: #130960 |
|
/milestone v1.33 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Resizing swap needs more consideration (#130111). For the purposes of unblocking InPlacePodVerticalScaling beta, resizes affecting swap limit configuration will be marked as infeasible. This is a temporary change and will be revisited in the future after beta.
Which issue(s) this PR fixes:
Fixes #130659
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: