Upgrade to golang 1.6 #22149

luxas · 2016-02-28T17:37:14Z

A second attempt to upgrade go version above go1.4
Merge ASAP after you've cut the release-1.2 branch and feel ready.
go1.6 should perform slightly better than go1.5, so this time it might work
@gmarek @wojtek-t @zmerlynn @mikedanese @brendandburns @ixdy @thockin

k8s-bot · 2016-02-28T17:41:19Z

GCE e2e build/test failed for commit 18f520dccd552134dec2bff5015df859fe9222e9.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

k8s-github-robot · 2016-02-28T17:44:42Z

Labelling this PR as size/M

luxas · 2016-02-28T17:46:50Z

@mikedanese Should we have an option to force build the kube-cross image when necessary?
In these cases that's needed.

mikedanese · 2016-02-28T18:24:35Z

build/build-image/cross/Dockerfile

@@ -15,7 +15,7 @@
 # This file creates a standard build environment for building cross
 # platform go binary for the architecture kubernetes cares about.

-FROM  golang:1.4.2
+FROM golang:1.6


please include the minor version. e.g. 1.6.0

mikedanese · 2016-02-28T18:26:22Z

.travis.yml and shippable.yml also need the version bump

mikedanese · 2016-02-28T18:27:56Z

Should we have an option to force build the kube-cross image when necessary?
In these cases that's needed.

What would it do? We need to push kube-cross before CI goes green right now. That seems like a reasonable check to have

luxas · 2016-02-28T19:06:35Z

@mikedanese Fixed. Now the kube-cross will be built if it isn't pushed.

mikedanese · 2016-02-28T19:18:38Z

I don't think that's a good idea. It allows CI to pass without pushing the image first which is a bad thing.

luxas · 2016-02-28T19:20:13Z

I'm fine with that. Do you have a better approach?

k8s-bot · 2016-02-28T19:48:57Z

GCE e2e build/test failed for commit f6472f5d9d173e2276f44bafa3497c9799c9955d.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

luxas · 2016-02-28T20:22:35Z

@mikedanese OK, what do you say about this then?
We'll update non-release CI to go1.6 in this PR before v1.2.
If you want, we may also merge the bump to go1.6 in build/build-image/cross before v1.2
If we do that, you should push v1.6.0-1 to gcr.io, but we'll not use it in build/common.sh for v1.2

If a v1.6.0-1 image would be pushed somehow, it would help a lot!

k8s-bot · 2016-02-28T20:41:04Z

GCE e2e build/test passed for commit 0fb8245a607dde8290ed467e85cb3655ef880c64.

k8s-github-robot · 2016-02-28T20:51:43Z

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

wojtek-t · 2016-02-29T07:11:14Z

Well - we deinifetly do not want to have this for 1.2, so I will get back to it once we are done with our 1.2 work.

luxas · 2016-02-29T11:22:00Z

Yeah, as I said in the first place. Didn't think you'd want it either. But just asked anyway...
I'm ready when you are ready :)

ixdy · 2016-02-29T20:57:42Z

hack/jenkins/test-image/Dockerfile

@@ -15,7 +15,7 @@
 # This file creates a build environment for building and running kubernetes
 # unit and integration tests

-FROM golang:1.5.3


should update the tag for this image (in the Makefile) as well

Thanks. Fixed.

k8s-bot · 2016-03-01T10:17:42Z

GCE e2e build/test passed for commit 8647e666c0b82e702e904d07e98ad021162d7f48.

wojtek-t · 2016-03-04T12:02:24Z

@luxas - FYI, we have a bunch of unit tests failing with Go 1.6, so there is long way to do before we do this...

luxas · 2016-03-04T16:42:26Z

Thanks for the info, good to know.
But really sad things are failing.
Would intermediate 1.4.2 => 1.5.3 => 1.6.0 be a better migration, so the step wouldn't be so huge?
Just thinking out loud...

wojtek-t · 2016-04-04T22:54:14Z

shippable.yml

@@ -4,7 +4,7 @@ language: go

 matrix:
 include:
- - go: 1.5.3
+ - go: 1.6.0


@spxtr @ixdy
Since we are no longer using shippable - can't we just remove this whole file?

Yes, probably best to do that in a separate PR though.

#23845 out for review

lavalamp · 2016-04-05T00:11:42Z

LGTM

timothysc · 2016-04-05T12:53:08Z

Can someone apply the label, given multiple lgtms?

eparis · 2016-04-05T14:19:11Z

I'll be the one. /me wonders why @timothysc didn't do it :)

k8s-github-robot · 2016-04-05T14:23:51Z

@k8s-bot test this

Tests are more than 48 hours old. Re-running tests.

timothysc · 2016-04-05T14:28:59Z

@eparis didn't want to stomp on toes. ;-)

eparis · 2016-04-05T14:30:31Z

STOMP!

k8s-bot · 2016-04-05T15:00:35Z

GCE e2e build/test passed for commit 2928d0a.

k8s-github-robot · 2016-04-05T17:35:45Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-04-05T18:14:07Z

GCE e2e build/test passed for commit 2928d0a.

k8s-github-robot · 2016-04-05T18:49:41Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-04-05T19:30:52Z

GCE e2e build/test passed for commit 2928d0a.

k8s-github-robot · 2016-04-05T19:54:37Z

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

k8s-bot · 2016-04-05T20:26:17Z

GCE e2e build/test passed for commit 2928d0a.

k8s-github-robot · 2016-04-05T20:26:18Z

Automatic merge from submit-queue

spxtr · 2016-04-05T20:35:49Z

Here we go!

~~It occurs to me that we might need to up the timeout on the kubernetes-build job.~~ Nope, it's still well within the limit :)

hongchaodeng · 2016-04-06T05:06:47Z

./test/e2e_node/jenkins/e2e-node-jenkins.sh seems to be using the go on host. This might still be using go 1.4 depending on the host.

@spxtr @luxas Is there any plan for keep that part up-to-date as well?

/cc @xiang90

@wojtek-t

Automatic merge from submit-queue Add a note about supported go version Broke out from #22149 @wojtek-t

@gmarek

Automatic merge from submit-queue Up to golang 1.6 A second attempt to upgrade go version above `go1.4` Merge ASAP after you've cut the `release-1.2` branch and feel ready. `go1.6` should perform slightly better than `go1.5`, so this time it might work @gmarek @wojtek-t @zmerlynn @mikedanese @brendandburns @ixdy @thockin

@wojtek-t

Automatic merge from submit-queue Add a note about supported go version Broke out from kubernetes#22149 @wojtek-t

…-discovery UPSTREAM: 00000: wait for CRD discovery to be successful once before Origin-commit: 9ffad072ee9a512a7344dba700b5a15bcad5349a

googlebot added the cla: yes label Feb 28, 2016

k8s-github-robot assigned zmerlynn Feb 28, 2016

k8s-github-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 28, 2016

mikedanese reviewed Feb 28, 2016
View reviewed changes

mikedanese assigned wojtek-t and unassigned zmerlynn Feb 28, 2016

luxas force-pushed the onedotsix branch from 18f520d to f6472f5 Compare February 28, 2016 19:05

luxas force-pushed the onedotsix branch from f6472f5 to 0fb8245 Compare February 28, 2016 20:10

k8s-github-robot added the needs-ok-to-merge label Feb 28, 2016

ixdy reviewed Feb 29, 2016
View reviewed changes

luxas force-pushed the onedotsix branch from 0fb8245 to 8647e66 Compare March 1, 2016 09:48

This was referenced Mar 4, 2016

Go 1.6 seems to irritate build-go #22457

Closed

Upgrading to go 1.6 #22039

Closed

wojtek-t reviewed Apr 4, 2016
View reviewed changes

eparis added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 5, 2016

k8s-github-robot merged commit 4f32951 into kubernetes:master Apr 5, 2016

hongchaodeng mentioned this pull request Apr 6, 2016

Up to golang 1.6 in golang.sh #23915

Closed

This was referenced Apr 6, 2016

Add a note about supported go version #23925

Merged

Build Kubernetes, etcd and flannel for arm64 and ppc64le #23931

Merged

david-mcmahon changed the title ~~Up to golang 1.6~~ Upgrade to golang 1.6 Apr 6, 2016

k8s-github-robot pushed a commit that referenced this pull request Apr 6, 2016

Merge pull request #23925 from luxas/go_version_support

b141c69

Automatic merge from submit-queue Add a note about supported go version Broke out from #22149 @wojtek-t

luxas mentioned this pull request May 15, 2016

gcr.io/google_containers/hyperkube-arm:v1.2.3 missing #24785

Closed

ikehz mentioned this pull request Jun 2, 2016

v1.2 "Kubectl client Simple pod should support port-forward" hanging when run with v1.3 Kubectl #26594

Closed

xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016

Merge pull request kubernetes#23925 from luxas/go_version_support

87f9936

Automatic merge from submit-queue Add a note about supported go version Broke out from kubernetes#22149 @wojtek-t

Upgrade to golang 1.6 #22149

Upgrade to golang 1.6 #22149

Conversation

luxas commented Feb 28, 2016

k8s-bot commented Feb 28, 2016

k8s-github-robot commented Feb 28, 2016

luxas commented Feb 28, 2016

mikedanese Feb 28, 2016

Choose a reason for hiding this comment

mikedanese commented Feb 28, 2016

mikedanese commented Feb 28, 2016

luxas commented Feb 28, 2016

mikedanese commented Feb 28, 2016

luxas commented Feb 28, 2016

k8s-bot commented Feb 28, 2016

luxas commented Feb 28, 2016

k8s-bot commented Feb 28, 2016

k8s-github-robot commented Feb 28, 2016

wojtek-t commented Feb 29, 2016

luxas commented Feb 29, 2016

ixdy Feb 29, 2016

Choose a reason for hiding this comment

luxas Mar 1, 2016

Choose a reason for hiding this comment

k8s-bot commented Mar 1, 2016

wojtek-t commented Mar 4, 2016

luxas commented Mar 4, 2016

wojtek-t Apr 4, 2016

Choose a reason for hiding this comment

spxtr Apr 4, 2016

Choose a reason for hiding this comment

wojtek-t Apr 4, 2016

Choose a reason for hiding this comment

lavalamp commented Apr 5, 2016

timothysc commented Apr 5, 2016

eparis commented Apr 5, 2016

k8s-github-robot commented Apr 5, 2016

timothysc commented Apr 5, 2016

eparis commented Apr 5, 2016

k8s-bot commented Apr 5, 2016

k8s-github-robot commented Apr 5, 2016

k8s-bot commented Apr 5, 2016

k8s-github-robot commented Apr 5, 2016

k8s-bot commented Apr 5, 2016

k8s-github-robot commented Apr 5, 2016

k8s-bot commented Apr 5, 2016

k8s-github-robot commented Apr 5, 2016

spxtr commented Apr 5, 2016

hongchaodeng commented Apr 6, 2016