Remove RunInContainer interface in Kubelet Runtime interface #24921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feiskyer
changed the title
k8s-github-robot
added
size/L
1 similar comment
yujuhong
added
release-note-none
|
@feiskyer, thanks a lot for cleaning this up! LGTM. |
yujuhong
added
the
lgtm
|
@yujuhong Am I missing something, k8s-bot has tested this for several times, but not merged it. |
|
@feiskyer nope, we just have a long queue of PRs to merge, and the tree was closed half of the time due to blocking build/test failures. |
|
GCE e2e build/test passed for commit 831203c. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 831203c. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Aug 20, 2016
Automatic merge from submit-queue Always return command output for exec probes and kubelet RunInContainer Always return command output for exec probes and kubelet RunInContainer, even if the command invocation returns nonzero. When #24921 replaced RunInContainer with ExecInContainer, it introduced a change where an exec probe that failed no longer included the stdout/stderr from the probe in the event. For example, when running at log level 4, you see: ``` I0816 15:01:36.259826 29713 exec.go:38] Exec probe response: "Failed to access the status endpoint : HTTP Error 404: Not Found.\nHawkular metrics has only been running for 7\n seconds not aborting yet.\n" ``` But the event looks like this: ``` 54s 22s 5 hawkular-metrics-hjme4 Pod spec.containers{hawkular-metrics} Warning Unhealthy {kubelet corbeau} Readiness probe failed: ``` Note the absence of the exec probe response after "Readiness probe failed". This PR restores the previous behavior. cc @kubernetes/rh-cluster-infra @mwringe xref openshift/origin#10424
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to #24689, we should merge RunInContainer and ExecInContainer in the container runtime interface.
@yujuhong @kubernetes/sig-node