Add federation api and cm servers to hyperkube #27586
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
3 similar comments
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
colhom
force-pushed
the
federation-hyperkube
branch
from
bd40bb1
to
8b2d1f3
Compare
|
CLAs look good, thanks! |
k8s-github-robot
added
size/M
|
@quinton-hoole @nikhiljindal Is this one for v1.3? |
|
@luxas given that federation is a blocker, I would think exposing federation binaries via hyperkube is mandatory functionality for v1.3. |
|
@mikedanese @ixdy @lavalamp Someone that may trigger the tests? |
|
add to whitelist |
|
My apologies, I overlooked this PR. Sorting it out now. |
|
ok to test |
ghost
added
release-note
|
Verification failures do not seem related to this PR: Verifying ./hack/../hack/verify-govet.sh
federation/pkg/dnsprovider/providers/aws/route53/testing/route53api.go:79: arg change.ResourceRecordSet.Name for printf verb %s of wrong type: *string
federation/pkg/dnsprovider/providers/aws/route53/testing/route53api.go:84: arg change.ResourceRecordSet.Name for printf verb %s of wrong type: *string
federation/pkg/dnsprovider/providers/aws/route53/testing/route53api.go:105: arg input.Name for printf verb %s of wrong type: *string
federation/pkg/dnsprovider/providers/google/clouddns/clouddns.go:110: k8s.io/kubernetes/federation/pkg/dnsprovider/providers/google/clouddns/internal/stubs.ManagedZone composite literal uses unkeyed fields
FAILED ./hack/../hack/verify-govet.sh 342s
....
Verifying ./hack/../hack/verify-symbols.sh
Go version: go version go1.6.2 linux/amd64
+++ [0617 13:06:17] Building the toolchain targets:
k8s.io/kubernetes/hack/cmd/teststale
+++ [0617 13:06:18] Building go targets for linux/amd64:
cmd/hyperkube
+++ [0617 13:07:01] Placing binaries
Found bad symbol 'testing[.]':
00000000042371c0 r go.importpath.k8s.io/kubernetes/federation/pkg/dnsprovider/providers/aws/route53/testing.
00000000057cb858 b go.itab.*k8s.io/kubernetes/vendor/github.com/aws/aws-sdk-go/service/route53.Route53.k8s.io/kubernetes/federation/pkg/dnsprovider/providers/aws/route53/testing.Route53API
000000000188e470 t k8s.io/kubernetes/federation/pkg/dnsprovider/providers/aws/route53/testing.init
00000000057c85db b k8s.io/kubernetes/federation/pkg/dnsprovider/providers/aws/route53/testing.initdone.
FAILED ./hack/../hack/verify-symbols.sh 47s |
|
@goltermann |
k8s-github-robot
removed
the
lgtm
goltermann
added
the
lgtm
|
@k8s-bot verify this issue: #IGNORE |
|
@colhom No idea why this is the only PR hung up on those vet issues, but they're being fixed by @mikedanese in #27558. |
|
@k8s-bot verify this issue: #IGNORE |
|
@colhom the vet errors are cleaned up, but the symbols issue does appear to be related to your PR. Take a look at hack/verify-symbols.sh. It's flagging that your PR now builds in symbols named "testing" into hyperkube. @quinton-hoole any ideas? Should we alter the regex at https://github.com/kubernetes/kubernetes/blob/master/hack/verify-symbols.sh#L32, or alter something in federation code? |
|
@goltermann @colhom I'm guessing that this might be tripping up the verify-symbols.sh check. The easiest might be to rename that package. I can send in a PR for that. I'm not familiar enough with the aims behind verify-symbols to know for sure whether that would be subverting a good check or not. That package is so minute that I don' think it makes much difference whether it's in or out of the production binaries. |
ghost
mentioned this pull request
|
#27734 should do the trick. |
…vider-route53-testing-package Automatic merge from submit-queue Rename dnsprovider/providers/aws/route53/internal/testing to stubs. Resolves #27586 (comment) cc @colhom @goltermann
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
2 similar comments
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
@k8s-bot ok to test |
|
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
|
GCE e2e build/test passed for commit 8b2d1f3. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e build/test passed for commit 8b2d1f3. |
|
Automatic merge from submit-queue |
\cc @nikhiljindal @quinton-hoole