-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: eviction: allow minimum reclaim as percentage #33392
kubelet: eviction: allow minimum reclaim as percentage #33392
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things
- the kubelet -h text needs updating
- this should have a release-note
- it would be good if you can update kubelet-eviction.md design doc
- we will need a doc follow-on.
}{ | ||
"BothMet": { | ||
thresholds: specifiecThresholds, | ||
enforceMinRelaim: false, | ||
thresholds: specifiecThresholds, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: specificThresholds
@derekwaynecarr I pushed the typo fix and updated the PR description with a release note. From a documentation perspective (-h, design doc, kube docs) I don't think anything needs to be updated. The soft and hard thresholds don't call out explicitly that they support absolute values and percentages either. If anything the docs should have said that |
@sjenning - squash then lgtm, @ronnielai fyi |
eede21d
to
f52dce9
Compare
@derekwaynecarr rebased and squashed |
flaked #33838 |
@k8s-bot unit test this |
@k8s-bot gke e2e test this |
Jenkins unit/integration failed for commit f52dce9. Full PR test history. The magic incantation to run this job again is |
I think this is the fix for the |
@k8s-bot unit test this |
Jenkins GKE smoke e2e failed for commit f52dce9. Full PR test history. The magic incantation to run this job again is |
Automatic merge from submit-queue |
Yay! |
Fixes #33354
xref #32537
Release note:
@derekwaynecarr @vishh @mtaufen
This change is