Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the fake RESTClient usable by all the API groups, not just core. #35492

Merged
merged 1 commit into from
Oct 27, 2016
Merged

Make the fake RESTClient usable by all the API groups, not just core. #35492

merged 1 commit into from
Oct 27, 2016

Conversation

madhusudancs
Copy link
Contributor

@madhusudancs madhusudancs commented Oct 25, 2016 •
edited
Loading

cc @kubernetes/sig-cluster-federation @quinton-hoole @nikhiljindal

This change is Reviewable

@madhusudancs madhusudancs added release-note Denotes a PR that will be considered when it comes time to generate release notes. area/cluster-federation labels Oct 25, 2016
@madhusudancs madhusudancs added this to the v1.5 milestone Oct 25, 2016
@madhusudancs madhusudancs mentioned this pull request Oct 25, 2016
Merged
@k8s-github-robot k8s-github-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 25, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit ccb0e1a. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@k8s-ci-robot
Copy link
Contributor

Jenkins GCE e2e failed for commit ccb0e1a. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@nikhiljindal
Copy link
Contributor

Last commit LGTM.
I didnt look at the first commit closely, but doesnt look like the second commit needs to be blocked on the first one.
Remove first commit from this PR and submit?

@madhusudancs
Copy link
Contributor Author

@nikhiljindal thanks!

Remove first commit from this PR and submit?

Sure, I will do that. The PRs are not related anyway. I have kept them in order just to have a linear history so I can build and test any PR. I don't actually care about the order.

@madhusudancs madhusudancs force-pushed the federation-kubefed-00 branch from ccb0e1a to 63e3175 Compare October 26, 2016 07:21
@madhusudancs madhusudancs added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2016
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 26, 2016
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit da3d03f into kubernetes:master Oct 27, 2016
k8s-github-robot pushed a commit that referenced this pull request Nov 2, 2016
Merge pull request #35493 from madhusudancs/federation-kubefed-01
df8db65 
Automatic merge from submit-queue

[Federation][join-01] Implement `kubefed join` command.

Supersedes PR #35155.

Please review only the last commit here. This is based on PR #35492 which will be reviewed independently.

I will add a release note separately for this entire feature, so please don't worry too much about the release note here in the PR.

Design Doc: PR #34484

cc @kubernetes/sig-cluster-federation @quinton-hoole @mwielgus
@madhusudancs madhusudancs deleted the federation-kubefed-00 branch November 4, 2016 17:32
@madhusudancs madhusudancs mentioned this pull request Nov 17, 2016
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
6 participants
@madhusudancs @k8s-ci-robot @nikhiljindal @k8s-github-robot @googlebot @mwielgus