Remove unused WaitForDetach from Detacher interface and plugins #35629
Conversation
|
Can a kubernetes member verify that this patch is reasonable to test? If so, please reply with "@k8s-bot ok to test" on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands will still work. Regular contributors should join the org to skip this step. If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository. |
|
@kubernetes/sig-storage |
|
@k8s-bot ok to test |
|
@kubernetes/sig-openstack |
k8s-github-robot
added
size/L
|
Jenkins GCI GCE e2e failed for commit 66fed5fcb3338ccd5a691167bac2eda7dc184106. Full PR test history. The magic incantation to run this job again is |
|
Jenkins GCE e2e failed for commit 66fed5fcb3338ccd5a691167bac2eda7dc184106. Full PR test history. The magic incantation to run this job again is |
|
Jenkins GCE etcd3 e2e failed for commit 66fed5fcb3338ccd5a691167bac2eda7dc184106. Full PR test history. The magic incantation to run this job again is |
|
@saad-ali, do you know the original purpose/use of WaitForDetach function? |
|
Heh, all tests failing. there must be some dependency on some changes from within the original PR this was extracted from, I'll fixup tomorrow. |
This has been unused since 542f2dc, and relies on deviceName, which can no longer be relied upon (see issue kubernetes#33128). This needs to be removed now, as part of kubernetes#33128, as the code can't be updated to attempt device detection and fallback through to the Cinder provided deviceName, as detection "fails" when the device is gone, and if cinder has reported a deviceName that another volume has used in relaity, then this will block forever (or until the other, unreleated, volume has been detached)
kiall
force-pushed
the
bug/33128-unused-waitfordetach
branch
from
66fed5f to
ccb8d53
Compare
|
@saad-ali all done, should be ready to LGTM now |
saad-ali
added
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Automatic merge from submit-queue (batch tested with PRs 57366, 57779). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove unused command waitfordetach from flex volume driver **What this PR does / why we need it**: Clean unused code. **Special notes for your reviewer**: See #35629 Original PR is #50754 , the PR's repo has bean deleted，so I create a new PR and merge upstream for test. **Release note**: ```release-note NONE ```
…tfordetach Automatic merge from submit-queue Remove unused WaitForDetach from Detacher interface and plugins See issue kubernetes#33128 and PR kubernetes#33270 We can't rely on the device name provided by OpenStack Cinder, and thus must perform detection based on the drive serial number (aka It's cinder ID) on the kubelet itself. This needs to be removed now, as part of kubernetes#33128, as the code can't be updated to attempt device detection and fallback through to the Cinder provided deviceName, as detection "fails" when the device is gone, and if cinder has reported a deviceName that another volume has used in relaity, then this will block forever (or until the other, unreleated, volume has been detached)
See issue #33128 and PR #33270
We can't rely on the device name provided by OpenStack Cinder, and thus
must perform detection based on the drive serial number (aka It's cinder ID)
on the kubelet itself.
This needs to be removed now, as part of #33128, as the code can't be
updated to attempt device detection and fallback through to the Cinder
provided deviceName, as detection "fails" when the device is gone, and
if cinder has reported a deviceName that another volume has used in
relaity, then this will block forever (or until the other, unreleated,
volume has been detached)
This change is