Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove archived clientset #35928

Merged
merged 1 commit into from
Nov 1, 2016
Merged

Remove archived clientset #35928

merged 1 commit into from
Nov 1, 2016

Conversation

caesarxuchao
Copy link
Member

@caesarxuchao caesarxuchao commented Oct 31, 2016 •
edited
Loading

We have client-go now, no need to keep archived clientset in master of k8s.io/kubernetes.

Also updated the client-gen README.

Fix #35803.

cc @mikedanese

The main kubernetes repository stops hosting archived version of released clients. Please use [client-go](https://github.com/kubernetes/client-go).

This change is Reviewable

@mikedanese
Copy link
Member

Thanks.

@k8s-github-robot k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Oct 31, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins GKE smoke e2e failed for commit 5f11785. Full PR test history.

The magic incantation to run this job again is @k8s-bot cvm gke e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@caesarxuchao caesarxuchao assigned nikhiljindal and unassigned ghost Oct 31, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins verification failed for commit 5f11785. Full PR test history.

The magic incantation to run this job again is @k8s-bot verify test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

nikhiljindal
nikhiljindal reviewed Oct 31, 2016
View reviewed changes
docs/devel/generating-clientset.md
1.2 release, we will create release_1_3 clientset and keep it updated until we
cut release 1.3.

To get stable clientsets, please refer to the [client-go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably add a note saying new code should use client-go and we are in the process of updating existing code to use client-go. Perhaps also add link to the issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Will do.

@nikhiljindal
Copy link
Contributor

LGTM with one suggestion for README

remove release_1_4
4cf7adf 
remove archived federation clientsets
update README
@caesarxuchao
Copy link
Member Author

Done. Applying the lgtm. Thanks for the suggestion.

@caesarxuchao caesarxuchao added release-note Denotes a PR that will be considered when it comes time to generate release notes. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels Oct 31, 2016
@k8s-ci-robot
Copy link
Contributor

Jenkins unit/integration failed for commit 4cf7adf. Full PR test history.

The magic incantation to run this job again is @k8s-bot unit test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@ghost
Copy link

ghost commented Oct 31, 2016

@k8s-bot federation gce e2e test this

@caesarxuchao
Copy link
Member Author

@k8s-bot unit test this

@caesarxuchao
Copy link
Member Author

@k8s-bot federation gce e2e test this

@k8s-ci-robot
Copy link
Contributor

Jenkins Federation GCE e2e failed for commit 4cf7adf. Full PR test history.

The magic incantation to run this job again is @k8s-bot federation gce e2e test this. Please help us cut down flakes by linking to an open flake issue when you hit one in your PR.

@nikhiljindal
Copy link
Contributor

federation e2e timed out.
Since this PR is just deleting old clients, I think its enough to just verify that build is not broken.
So this should be fine to merge.

@caesarxuchao caesarxuchao added this to the v1.5 milestone Nov 1, 2016
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit cc84673 into kubernetes:master Nov 1, 2016
@chentao1596 chentao1596 mentioned this pull request Dec 5, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikhiljindal nikhiljindal nikhiljindal left review comments

Assignees

@nikhiljindal nikhiljindal

Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
6 participants
@caesarxuchao @mikedanese @k8s-ci-robot @nikhiljindal @k8s-github-robot @googlebot