Avoid setting S_ISGID on files in volumes #36386
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Directories in volumes are set S_ISGID to ensure files created inside them inherit group ownership. Currently, files are also set S_ISGID however this is not relevant to the original intent, and indicates 'mandatory file locking' (stat(2)). With this commit, only directories are set S_ISGID.
sjenning
force-pushed
the
fix-secret-file-mode
branch
from
a305a21
to
67f3134
Compare
|
CLAs look good, thanks! |
ncdc
added
the
release-note
ncdc
changed the title
k8s-github-robot
added
the
size/XS
ncdc
added
the
lgtm
|
Release-czar approved post-code freeze merge--This was LGTMed and in the merge-queue at code freeze time for 1.5. Leaving 1.5 milestone to let it gets merged after code freeze. |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Some applications are having issues with setting the S_ISGID bit on files in volumes. We intend to do this for directories so that the group ID is inherited, but not files for which S_ISGID indicates madatory file locking https://linux.die.net/man/2/stat
xref https://bugzilla.redhat.com/show_bug.cgi?id=1387306
@ncdc @derekwaynecarr @pmorie
This change is