-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set NetworkInterfaces and Subnets to nil before updating Azure security groups #40405
Set NetworkInterfaces and Subnets to nil before updating Azure security groups #40405
Conversation
Hi @codablock. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Is this the only validation blip? I'm worried about the loadbalancer updates as well. |
c55838f
to
bf28a9b
Compare
I just rechecked and retested and LB's are updated as expected. Which checking, I figured out that the same workaround was needed for the deletion path as well and added it to the PR. |
lgtm then. |
@brendandburns Can you check this PR and give a LGTM maybe? |
@k8s-bot ok to test /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: brendandburns Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@saad-ali fyi for the cherry-pick, we'd like to get this into 1.5.3... |
Removing label |
Removing label |
@k8s-bot cri node e2e test this |
I'd assume CI failure is not related to this PR. |
@k8s-bot kops aws e2e test this |
Automatic merge from submit-queue |
Commit found in the "release-1.5" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
What this PR does / why we need it: This is a workaround until we have an upstream fix in azure-sdk-for-go/go-autorest. Corresponding issues are #40332 and Azure/go-autorest#112
In k8s 1.5.2, an update to azure-sdk-for-go was cherry-picked, which broke creation/updating of LBs on Azure. As we should have it back to a working state ASAP, I'd like to do a workaround for now and later when the upstream fix comes in, remove the workaround again.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #40332Release note:
CC @colemickens