-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ceph-secret type to kubernetes.io/rbd in kubernetes-master charm #44635
Fix ceph-secret type to kubernetes.io/rbd in kubernetes-master charm #44635
Conversation
Hi @Cynerva. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @chuckbutler I believe you were around when our ceph operational code was originally added. Can you review this change? |
This is +1 LGTM. I had no clue this was a schema type. looking at https://github.com/kubernetes/kubernetes/tree/master/examples/persistent-volume-provisioning i see this is clearly outlined. Thanks for the fix @Cynerva |
/approve |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cynerva, chuckbutler
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@k8s-bot unit test this |
Automatic merge from submit-queue |
What this PR does / why we need it:
This fixes the type of the ceph-secret secret that's created by the kubernetes-master charm.
Without the
kubernetes.io/rbd
type, automatic provisioning of PVCs doesn't work.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Release note: