Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the elasticsearch template #45952

Merged
merged 1 commit into from
May 23, 2017

Conversation

harryge00
Copy link
Contributor

@harryge00 harryge00 commented May 17, 2017

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

NONE

Loading file-based index template has been disabled since 2.0.0-beta1 version of Elasticsearch. https://www.elastic.co/guide/en/elasticsearch/reference/2.0/breaking_20_index_api_changes.html#_file_based_index_templates

So the template-k8s-logstash.json is not longer useful.

On the other hand, as #25127 indicated, we might better curl the elasticsearch API to load this template.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @harryge00. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels May 17, 2017
@piosz piosz removed their assignment May 17, 2017
@piosz
Copy link
Member

piosz commented May 17, 2017

cc @crassirostris

@coffeepac
Copy link
Contributor

coffeepac commented May 17, 2017

@harryge00 looks good and thank you, can you please add a release note for this? Exact syntax to update your description is here

@coffeepac
Copy link
Contributor

@k8s-bot ok to test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 17, 2017
@k8s-github-robot k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels May 18, 2017
@harryge00
Copy link
Contributor Author

@coffeepac I have added release notes

@crassirostris
Copy link

@harryge00 @coffeepac I think something like removing files should not be in the release notes. Release notes exist for the users to track behavior changes that might affect them. If that change doesn't change anything, then I personally think release notes are not necessary. Otherwise, the behavior changes should be described, not developer's actions, e.g. 'fluentd-elasticsearch deployment index schema template is now set up by Elasticsearch'

@harryge00 does removing this file changes the behavior?

@coffeepac do you agree?

@coffeepac
Copy link
Contributor

@harryge00 thank you!

@crassirostris the file may be used be someone who has built some automation around using this file. that automation would break. if that bar is too low then adding the no-op release note is fine with me. we do need something in the release note or the merge bot won't merge it.

@crassirostris
Copy link

@coffeepac It's possible to add release-notes-none label

@coffeepac
Copy link
Contributor

@crassirostris so it can be. good to know. I was letting @harryge00 decide if there should be an actual note or a no-note.

I'm fine either way, this doesn't affect the behavior of the specified version of ES.

@crassirostris
Copy link

Thanks!

@harryge00
Copy link
Contributor Author

harryge00 commented May 19, 2017

I agree that the removal does not affect Elasticsearch behavior, whose version is later than v2.0.0-beta1 . @coffeepac @crassirostris

If someone has built some auomation around this file, they should have their own fork, because they also need a script in this es-image to do automation. Adding a script, which automatically loads this template, is a possible way to solve #25127. But it is a bit hacky, we have to check the elasticsearch is ready and then curl elasticsearch API to load it, with retries...

@coffeepac
Copy link
Contributor

@harryge00 okay, then no release is preferred. can you please either remove the release note I asked you to add or replace it with NONE?

@harryge00
Copy link
Contributor Author

@coffeepac updated

@coffeepac
Copy link
Contributor

/lgtm /approve

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2017
@coffeepac
Copy link
Contributor

lgtm

@crassirostris
Copy link

/lgtm

We'll look into the problem

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: coffeepac, crassirostris, harryge00

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 46201, 45952, 45427, 46247, 46062)

@k8s-github-robot k8s-github-robot merged commit 2718429 into kubernetes:master May 23, 2017
@k8s-ci-robot
Copy link
Contributor

@harryge00: The following test(s) failed:

Test name Commit Details Rerun command
pull-kubernetes-federation-e2e-gce d3fd956 link @k8s-bot pull-kubernetes-federation-e2e-gce test this
pull-kubernetes-e2e-gce-etcd3 d3fd956 link @k8s-bot pull-kubernetes-e2e-gce-etcd3 test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants