Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: fix broken kubeadm init --config flag #48915

Merged
merged 1 commit into from
Jul 14, 2017
Merged

kubeadm: fix broken kubeadm init --config flag #48915

merged 1 commit into from
Jul 14, 2017

Commits on Jul 13, 2017

  1. kubeadm: fix broken kubeadm init --config flag. 

    This code was changed in ea19649 to validate that `--config` wasn't passed along with other flags. Unfortunately, the implementation was checking `PersistentFlags()`, which was not parsed at the point it was being validated. The result was that `--config` was _always_ rejected, not just when it was specified alongside other flags.

The fix is to use `Flags()` instead, which contains the expected data.
    @mattmoyer
    mattmoyer committed Jul 13, 2017
    Configuration menu
    Copy the full SHA
    ae35377 View commit details
    Browse the repository at this point in the history