-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add v1beta2.DaemonSet #49071
Add v1beta2.DaemonSet #49071
Conversation
@foxish Please add a reference to issue/proposal for context. |
fc0ce8b
to
01b7051
Compare
/test pull-kubernetes-e2e-gce-etcd3 |
Tests expected to fail. No autogenerated changes added. Waiting for #48746 to merge. |
@@ -29,6 +29,191 @@ const ( | |||
StatefulSetRevisionLabel = ControllerRevisionHashLabelKey | |||
) | |||
|
|||
type DaemonSetUpdateStrategy struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to mark these new APIs WIP (see other structs in this file) as we're going to break it. Please put DaemonSet APIs in the roughly same location as extensions/v1beta1 (i.e. after Deployment).
@@ -175,7 +175,8 @@ func ClusterRoles() []rbac.ClusterRole { | |||
rbac.NewRule("impersonate").Groups(legacyGroup).Resources("serviceaccounts").RuleOrDie(), | |||
|
|||
rbac.NewRule(ReadWrite...).Groups(appsGroup).Resources("statefulsets", | |||
"deployments", "deployments/scale", "deployments/rollback").RuleOrDie(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DaemonSets were not in this list before because they could evict other workloads outside of the namespace. @liggitt on intent from sig-auth here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop the admin/edit/view role change from this PR and open a follow up to discuss with @kubernetes/sig-scheduling-pr-reviews and @kubernetes/sig-node-pr-reviews... I'm not sure of the current state of daemonset-spawned pod priority
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed changes to the roles. Thanks!
/approve One comment for @kubernetes/sig-auth-pr-reviews re daemonset in namespace admin role |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foxish, janetkuo, smarterclayton Associated issue: 49135 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
Readding LGTM based on previous. |
@foxish: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/test pull-kubernetes-kubemark-e2e-gce |
Automatic merge from submit-queue (batch tested with PRs 43443, 46193, 49071, 47252) |
…ation Automatic merge from submit-queue Cleanup DaemonSet templateGeneration **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49336 **Special notes for your reviewer**: /cc @janetkuo @foxish ~~Depends on #49071~~ (Merged) **Release note**: ```release-note None ```
Depends on #48746
Partly implements #49135