Add Italian translation for kubectl #50155

lucab85 · 2017-08-04T16:02:07Z

What this PR does / why we need it:
This PR provides first attempt to translate kubectl in Italian (related to #40645, #45573,
#45562, #40591, #46559).

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
No issues

Special notes for your reviewer:
This PR requires Italian people to assist in the review. I'm native in Italian with BS in Computer Science.

Adding Italian translation for kubectl

k8s-ci-robot · 2017-08-04T16:02:16Z

Hi @lucab85. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

lucab85 · 2017-08-04T16:13:21Z

/assign @brendandburns

cblecker

@lucab85 This is worth adding a release note. Could you please add a release note to the body of your PR (something like the below, but without the leading + signs).

+```release-note
+Adding it_IT translation for kubectl
+```

cblecker · 2017-08-04T23:44:46Z

pkg/util/i18n/i18n.go

@@ -38,6 +38,7 @@ var knownTranslations = map[string][]string{
 		"zh_CN",
 		"ja_JP",
 		"zh_TW",
+                "it_IT",


There's an extra whitespace here that isn't needed.

cblecker · 2017-08-05T16:19:25Z

/ok-to-test

cblecker · 2017-08-05T17:04:53Z

/retest

lucab85 · 2017-08-06T13:56:25Z

Please help me to solve the problem. I've tried to do hack/generate-bindata.sh as suggested in translations/README.md but suck with this error:

$ ./hack/generate-bindata.sh 
~/prj/github/kubernetes ~/prj/github/kubernetes
flag provided but not defined: -nometadata
Usage: go-bindata [options] <input directories>

  -debug=false: Do not embed the assets, but provide the embedding API. Contents will still be loaded from disk.
  -nocompress=false: Assets will *not* be GZIP compressed when this flag is specified.
  -nomemcopy=false: Use a .rodata hack to get rid of unnecessary memcopies. Refer to the documentation to see what implications this carries.
  -o="./bindata.go": Optional name of the output file to be generated.
  -pkg="main": Package name to use in the generated code.
  -prefix="": Optional path prefix to strip off asset names.
  -tags="": Optional set of uild tags to include.
  -version=false: Displays version information.

I'm using Ubuntu 16.04 + longsleep/golang-backports :

$ go version
warning: GOPATH set to GOROOT (/usr/lib/go-1.8/) has no effect
go version go1.8.3 linux/amd64
$ go-bindata --version
go-bindata 3.1.0 (Go runtime go1.2.1).
Copyright (c) 2010-2013, Jim Teeuwen.

cblecker · 2017-08-06T18:31:57Z

Try a make generated_files

lucab85 · 2017-08-08T06:40:02Z

Thank you @cblecker for your hint but doesn't solve my issue.
The script hack/generate-bindata.sh stuck on lines 46 and 69 invoking go-bindata with -nometadata option witch doesn't exist in the latest version of (3.0.7) so I removed this option and I was able to run the script and generate the pkg/generated/bindata.go file.

/retest

brendandburns · 2017-08-09T18:54:37Z

@lucab85 thanks for the PR. I'll look into either using an older version of go-bindata, or removing that flag...

brendandburns · 2017-08-09T18:56:04Z

@lucab85

Actually, I think if you re-run ./hack/generate-bindata.sh now that you patched the script, and commit the results it should work...

Let us know if it doesn't.

lucab85 · 2017-08-09T20:44:33Z

Thank you for your messages @brendandburns.
My latest commit (3c5f15f) already included the result of ./hack/generate-bindata.sh but unfortunately the build still failed as you can see above.
I hope somebody help me to address the issue.

cblecker · 2017-08-09T20:51:23Z

I think the version is off though.. it needs to match whatever CI is using so that it doesn't generate a diff

lucab85 · 2017-08-17T21:42:41Z

Please help me to understand the issue in the latest CI report.
Thank you in advance.

cblecker · 2017-08-17T21:57:03Z

I think it's because you're using a version of go-bindata compiled with go1.2.1.

Try running go get -u github.com/jteeuwen/go-bindata/... to download/compile/install, and then run a go-bindata -version to verify that your version matches:

$ go version && go-bindata -version
go version go1.8.3 darwin/amd64
go-bindata 3.1.0 (Go runtime go1.8.3).
Copyright (c) 2010-2013, Jim Teeuwen.

Lastly, 3.1.0 does support the -nometadata flag, so your changes to hack/generate-bindata.sh can be reverted.

cblecker · 2017-08-18T13:56:33Z

Looks like CI is passing now. Please squash your commits :)
Thanks for sticking with this!

brendandburns · 2017-08-22T04:25:42Z

Yeah, thanks for doing this, if you squash commits (git rebase -i HEAD~6) I'm happy to lgtm and merge.

lucab85 · 2017-08-22T06:59:57Z

Thank you @cblecker and @brendandburns for your support.
I hope that my squashed rebase with commit-id 96de8b9 works fine.

cblecker · 2017-08-22T16:04:02Z

@lucab85 It doesn't look like it worked, as there are 8 commits if you look here: https://github.com/kubernetes/kubernetes/pull/50155/commits

Another way to do it:
Looking at your branch (https://github.com/lucab85/kubernetes/commits/i18n-Italian), the last commit from the upstream is lucab85@9aa04c7

So the following should work:

# rebase off of that last upstream commit
git rebase -i 9aa04c7
# The commit named "Italian translation" (https://github.com/lucab85/kubernetes/commit/96de8b93adfc38dbdb31a06963c883d2e95435bb) should be set to "pick"
# All the "Merge Branch" commits can be set to "drop"

Try that and see if it works for you.

lucab85 · 2017-08-23T07:00:17Z

Thank you @cblecker. Wait for CI tests for my squashed commit 1044b0d.

lucab85 · 2017-08-23T12:36:22Z

/retest

cblecker · 2017-08-23T17:04:46Z

/retest

lucab85 · 2017-08-24T06:49:05Z

Yay @cblecker! Wait for lgtm!

cblecker · 2017-08-24T16:52:53Z

/lgtm
over to @brendandburns for approval

brendandburns · 2017-08-24T16:55:35Z

/approve no-issue

k8s-github-robot · 2017-08-24T16:56:13Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brendandburns, cblecker, lucab85

Associated issue: 40645

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

~~pkg/OWNERS~~ [brendandburns]
~~translations/kubectl/OWNERS~~ [brendandburns]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

lucab85 · 2017-08-24T19:17:27Z

Thank you again for your support and help @cblecker and @brendandburns

cblecker · 2017-08-24T19:27:19Z

You're welcome, and thanks for contributing :)

k8s-github-robot · 2017-08-25T14:58:10Z

Automatic merge from submit-queue (batch tested with PRs 46986, 51214, 51169, 50155, 51261)

Automatic merge from submit-queue Add German translation for kubectl **What this PR does / why we need it**: This PR provides a first attempt to translate kubectl in German (related to #40645, #45573, #45562, #40591, #46559, #50155). **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # No issues **Special notes for your reviewer**: This PR requires German people to assist in the review. I'm native in German with BSc in Business Information Technology. **Release note**: ```release-note Adding German translation for kubectl ```

Automatic merge from submit-queue (batch tested with PRs 50378, 51463, 50006, 51962, 51673). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.. Improved Italian translation for kubectl **What this PR does / why we need it:** This PR provides an improved Italian translation of kubectl (related to #50155). **Which issue this PR fixes** _(`optional, in fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)_: fixes # No issues **Special notes for your reviewer:** This PR requires Italian people to assist in the review. I'm native in Italian with BS in Computer Science. ```release-note Improved Italian translation for kubectl ```

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adds initial Korean translations for kubectl **What this PR does / why we need it**: This PR provides a first attempt to translate kubectl in Korean (related to kubernetes#51867, kubernetes#40645, kubernetes#45573, kubernetes#45562, kubernetes#40591, kubernetes#46559, kubernetes#50155). **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: No issues **Special notes for your reviewer**: This PR requires Korean people to assist in the review. I am native in Korean and also a translator & reviewer in Korean in OpenStack I18n team (http://stackalytics.com/?metric=translations&user_id=ianychoi ). **Release note**: ```release-note Adding initial Korean translation for kubectl ```

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2017

k8s-github-robot assigned lavalamp and brendandburns Aug 4, 2017

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Aug 4, 2017

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 4, 2017

cblecker reviewed Aug 4, 2017

View reviewed changes

k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels Aug 5, 2017

lucab85 changed the title ~~Italian translation~~ Add Italian translation for kubectl Aug 5, 2017

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 5, 2017

k8s-github-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 17, 2017

Italian translation

1044b0d

lucab85 force-pushed the i18n-Italian branch from ee23a93 to 1044b0d Compare August 23, 2017 06:55

k8s-ci-robot assigned cblecker Aug 24, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2017

k8s-github-robot merged commit 6a3647a into kubernetes:master Aug 25, 2017

lucab85 deleted the i18n-Italian branch August 25, 2017 15:00

lucab85 mentioned this pull request Aug 28, 2017

Improved Italian translation for kubectl #51463

Merged

Steffen911 mentioned this pull request Sep 3, 2017

Add German translation for kubectl #51867

Merged

ianychoi mentioned this pull request Apr 2, 2018

Adds initial Korean translations for kubectl #62040

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Italian translation for kubectl #50155

Add Italian translation for kubectl #50155

lucab85 commented Aug 4, 2017 •

edited

Loading

k8s-ci-robot commented Aug 4, 2017

lucab85 commented Aug 4, 2017

cblecker left a comment •

edited

Loading

cblecker Aug 4, 2017

cblecker commented Aug 5, 2017

cblecker commented Aug 5, 2017

lucab85 commented Aug 6, 2017

cblecker commented Aug 6, 2017

lucab85 commented Aug 8, 2017 •

edited

Loading

brendandburns commented Aug 9, 2017

brendandburns commented Aug 9, 2017

lucab85 commented Aug 9, 2017

cblecker commented Aug 9, 2017

lucab85 commented Aug 17, 2017

cblecker commented Aug 17, 2017

cblecker commented Aug 18, 2017

brendandburns commented Aug 22, 2017

lucab85 commented Aug 22, 2017

cblecker commented Aug 22, 2017

lucab85 commented Aug 23, 2017

lucab85 commented Aug 23, 2017

cblecker commented Aug 23, 2017

lucab85 commented Aug 24, 2017 •

edited

Loading

cblecker commented Aug 24, 2017

brendandburns commented Aug 24, 2017

k8s-github-robot commented Aug 24, 2017

lucab85 commented Aug 24, 2017

cblecker commented Aug 24, 2017

k8s-github-robot commented Aug 25, 2017

Add Italian translation for kubectl #50155

Add Italian translation for kubectl #50155

Conversation

lucab85 commented Aug 4, 2017 • edited Loading

k8s-ci-robot commented Aug 4, 2017

lucab85 commented Aug 4, 2017

cblecker left a comment • edited Loading

Choose a reason for hiding this comment

cblecker Aug 4, 2017

Choose a reason for hiding this comment

cblecker commented Aug 5, 2017

cblecker commented Aug 5, 2017

lucab85 commented Aug 6, 2017

cblecker commented Aug 6, 2017

lucab85 commented Aug 8, 2017 • edited Loading

brendandburns commented Aug 9, 2017

brendandburns commented Aug 9, 2017

lucab85 commented Aug 9, 2017

cblecker commented Aug 9, 2017

lucab85 commented Aug 17, 2017

cblecker commented Aug 17, 2017

cblecker commented Aug 18, 2017

brendandburns commented Aug 22, 2017

lucab85 commented Aug 22, 2017

cblecker commented Aug 22, 2017

lucab85 commented Aug 23, 2017

lucab85 commented Aug 23, 2017

cblecker commented Aug 23, 2017

lucab85 commented Aug 24, 2017 • edited Loading

cblecker commented Aug 24, 2017

brendandburns commented Aug 24, 2017

k8s-github-robot commented Aug 24, 2017

lucab85 commented Aug 24, 2017

cblecker commented Aug 24, 2017

k8s-github-robot commented Aug 25, 2017

lucab85 commented Aug 4, 2017 •

edited

Loading

cblecker left a comment •

edited

Loading

lucab85 commented Aug 8, 2017 •

edited

Loading

lucab85 commented Aug 24, 2017 •

edited

Loading