Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update gRPC to pick up data race fix #53128

Merged

Conversation

dixudx
Copy link
Member

@dixudx dixudx commented Sep 27, 2017

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #53124

Special notes for your reviewer:

Release note:

update gRPC to v1.6.0 to pick up data race fix grpc/grpc-go#1316 

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 27, 2017
@k8s-ci-robot
Copy link
Contributor

Hi @dixudx. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 27, 2017
@k8s-github-robot k8s-github-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 27, 2017
@caesarxuchao
Copy link
Member

/assign @roycaihw

@k8s-ci-robot
Copy link
Contributor

@caesarxuchao: GitHub didn't allow me to assign the following users: roycaihw.

Note that only kubernetes members can be assigned.

In response to this:

/assign @roycaihw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@caesarxuchao
Copy link
Member

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Sep 28, 2017
@roycaihw
Copy link
Member

lgtm

"ImportPath": "google.golang.org/grpc/grpclb/grpc_lb_v1",
"Comment": "v1.3.0",
"Rev": "d2e1b51f33ff8c5e4a15560ff049d200e83726c5"
"ImportPath": "google.golang.org/grpc/grpclb/grpc_lb_v1/messages",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dixudx do you know why the ImportPath changed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caesarxuchao It was grpc/grpc-go#1466 that made this changed.

@dims
Copy link
Member

dims commented Oct 9, 2017

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 9, 2017
@dixudx dixudx force-pushed the godeps_fix_grpc_data_race branch 2 times, most recently from 8b2569d to c479b6c Compare October 11, 2017 09:02
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2017
@dixudx dixudx force-pushed the godeps_fix_grpc_data_race branch 2 times, most recently from e92d49b to 673f140 Compare October 12, 2017 03:11
@caesarxuchao
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2017
@caesarxuchao
Copy link
Member

/retest

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2017
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 16, 2017
@dixudx
Copy link
Member Author

dixudx commented Oct 16, 2017

ping @caesarxuchao @jbeda Rebased. PTAL. It's ready for a review. Thanks.

@dixudx
Copy link
Member Author

dixudx commented Oct 16, 2017

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 16, 2017

@dixudx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-cross e92d49b link /test pull-kubernetes-cross

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dixudx
Copy link
Member Author

dixudx commented Oct 18, 2017

/retest

@caesarxuchao
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 19, 2017
@dixudx
Copy link
Member Author

dixudx commented Oct 20, 2017

ping @smarterclayton @wojtek-t for approval. Thanks

@wojtek-t
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: caesarxuchao, dixudx, wojtek-t

Associated issue: 53124

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2017
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 70960a5 into kubernetes:master Oct 20, 2017
@dixudx dixudx deleted the godeps_fix_grpc_data_race branch October 20, 2017 08:34
@shyamjvs
Copy link
Member

shyamjvs commented Oct 23, 2017

This PR broke large clusters i.e size >= 100 (see #51099 (comment)) due to lower grpc page size limit.

sebrandon1 pushed a commit to sebrandon1/kubernetes that referenced this pull request Oct 23, 2017
…ps_fix_grpc_data_race

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Revert "update gRPC to pick up data race fix"

Reverts kubernetes#53128

Fixes kubernetes#51099

cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx
sttts pushed a commit to sttts/apiserver that referenced this pull request Oct 24, 2017
…c_data_race

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Revert "update gRPC to pick up data race fix"

Reverts kubernetes/kubernetes#53128

Fixes kubernetes/kubernetes#51099

cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx

Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640
sttts pushed a commit to sttts/kube-aggregator that referenced this pull request Oct 24, 2017
…c_data_race

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Revert "update gRPC to pick up data race fix"

Reverts kubernetes/kubernetes#53128

Fixes kubernetes/kubernetes#51099

cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx

Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640
sttts pushed a commit to sttts/sample-apiserver that referenced this pull request Oct 24, 2017
…c_data_race

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Revert "update gRPC to pick up data race fix"

Reverts kubernetes/kubernetes#53128

Fixes kubernetes/kubernetes#51099

cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx

Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640
sttts pushed a commit to sttts/apiextensions-apiserver that referenced this pull request Oct 24, 2017
…c_data_race

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Revert "update gRPC to pick up data race fix"

Reverts kubernetes/kubernetes#53128

Fixes kubernetes/kubernetes#51099

cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx

Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640
sttts pushed a commit to sttts/apiserver that referenced this pull request Oct 26, 2017
…c_data_race

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Revert "update gRPC to pick up data race fix"

Reverts kubernetes/kubernetes#53128

Fixes kubernetes/kubernetes#51099

cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx

Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640
sttts pushed a commit to sttts/kube-aggregator that referenced this pull request Oct 26, 2017
…c_data_race

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Revert "update gRPC to pick up data race fix"

Reverts kubernetes/kubernetes#53128

Fixes kubernetes/kubernetes#51099

cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx

Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640
sttts pushed a commit to sttts/sample-apiserver that referenced this pull request Oct 26, 2017
…c_data_race

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Revert "update gRPC to pick up data race fix"

Reverts kubernetes/kubernetes#53128

Fixes kubernetes/kubernetes#51099

cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx

Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640
sttts pushed a commit to sttts/apiextensions-apiserver that referenced this pull request Oct 26, 2017
…c_data_race

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Revert "update gRPC to pick up data race fix"

Reverts kubernetes/kubernetes#53128

Fixes kubernetes/kubernetes#51099

cc @kubernetes/sig-api-machinery-bugs @wojtek-t @dixudx

Kubernetes-commit: bc69c92de15c2457b3566bbede5b363328e0d640
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gRPC library to pick up data race fix
10 participants