Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CIDR-aware proxy resolver for SPDY RoundTripper #54413

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Use CIDR-aware proxy resolver for SPDY RoundTripper #54413

merged 1 commit into from
Oct 23, 2017

Conversation

kad
Copy link
Member

@kad kad commented Oct 23, 2017 •
edited by jpbetz
Loading

What this PR does / why we need it: kubectl attach for example doesn't work if NO_PROXY specifies API endpoint IP via CIDR notation.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #54407

Special notes for your reviewer: Potentially it will be good to get that change to 1.8.x

Release note:

API machinery's httpstream/spdy calls now support CIDR notation for NO_PROXY

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2017
@liggitt
Copy link
Member

liggitt commented Oct 23, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kad, liggitt

Associated issue: 54407

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2017
@kad
Copy link
Member Author

kad commented Oct 23, 2017

/test pull-kubernetes-e2e-kops-aws

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit b1e2d7a into kubernetes:master Oct 23, 2017
@kad kad mentioned this pull request Oct 31, 2017
Merged
@ncdc ncdc added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Oct 31, 2017
k8s-github-robot pushed a commit that referenced this pull request Oct 31, 2017
Merge pull request #54866 from kad/automated-cherry-pick-of-#54413-or…
c62f4ad 
…igin-release-1.8

Automatic merge from submit-queue.

Automated cherry pick of #54413

Cherry pick of #54413 on release-1.8.

#54413: Use CIDR-aware proxy resolver for SPDY RoundTripper

**Release note**:
```release-note
- API machinery's httpstream/spdy calls now support CIDR notation for NO_PROXY
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ncdc ncdc

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubectl attach: client-go does not respect CIDRs in NO_PROXY
5 participants
@kad @liggitt @k8s-github-robot @ncdc @k8s-ci-robot