Add ipset binary for IPVS, context: Fixes #57321 #57648

Fsero · 2017-12-27T08:29:52Z

What this PR does / why we need it: Add ipset binary in debian-hyperkube-base which fixes issue 57321

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #57321

Special notes for your reviewer:

Release note:

Add ipset binary for IPVS to hyperkube docker image

k8s-ci-robot · 2017-12-27T10:52:00Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

dims · 2017-12-27T15:17:13Z

/ok-to-test

cblecker · 2017-12-27T19:23:21Z

Looks reasonable to me.

@Fsero Would you mind bumping the tag too?

kubernetes/build/debian-hyperkube-base/Makefile

Line 22 in 933272d

TAG=0.8

Fsero · 2017-12-27T19:28:17Z

@cblecker done! thanks for the review

Fsero · 2017-12-27T19:29:30Z

/assign @cblecker

cblecker · 2017-12-27T19:51:57Z

@Fsero Sorry, a couple other places that need updates too:

kubernetes/build/root/WORKSPACE

Line 76 in 933272d

tag = "0.8", # ignored, but kept here for documentation

kubernetes/cluster/images/hyperkube/Makefile

Line 24 in 933272d

BASEIMAGE=gcr.io/google-containers/debian-hyperkube-base-$(ARCH):0.8

Fsero · 2017-12-27T20:06:56Z

@cblecker sure, i'll change it and review it more. Thanks!

Fsero · 2017-12-27T21:07:13Z

@cblecker changed and reviewed, it looks like this is it

cblecker · 2018-02-12T06:55:19Z

@ixdy What else is needed here?

ixdy · 2018-02-12T21:49:23Z

@cblecker I was waiting for the WORKSPACE update.

we probably need to push a new image and update the hash again since #56937 merged ahead of this.

ixdy · 2018-02-13T00:09:51Z

@Fsero please update build/root/WORKSPACE to bump the debian-hyperkube-base-amd64 digest there. The new 0.9 tag has digest sha256:d83594ecd85345144584523e7fa5388467edf5d2dfa30d0a1bcbf184cddf4a7b.

ixdy · 2018-02-13T00:12:23Z

the patch should look something like:

diff --git a/build/root/WORKSPACE b/build/root/WORKSPACE
index 88f35e1eaf..adf0eed006 100644
--- a/build/root/WORKSPACE
+++ b/build/root/WORKSPACE
@@ -67,10 +67,10 @@ docker_pull(
 
 docker_pull(
     name = "debian-hyperkube-base-amd64",
-    digest = "sha256:fc1b461367730660ac5a40c1eb2d1b23221829acf8a892981c12361383b3742b",
+    digest = "sha256:d83594ecd85345144584523e7fa5388467edf5d2dfa30d0a1bcbf184cddf4a7b",
     registry = "k8s.gcr.io",
     repository = "debian-hyperkube-base-amd64",
-    tag = "0.8",  # ignored, but kept here for documentation
+    tag = "0.9",  # ignored, but kept here for documentation
 )
 
 docker_pull(

@tallclair

Automatic merge from submit-queue (batch tested with PRs 59298, 59773, 59772). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. bazel: update digests for debian-iptables-amd64 and busybox **What this PR does / why we need it**: I've pushed updated (rebased) versions of the `debian-base-ARCH:0.3` and `debian-iptables-ARCH:v10` images. Since bazel uses the sha256 digest instead of the tag, we need to update those accordingly. I also bumped the busybox digest, which hasn't been updated since last summer. This is updating it from v1.26.2 to v1.28.0. Note that the non-bazel build process uses `busybox:latest`, and so has already been using busybox v1.28.0. **Special notes for your reviewer**: We will update the hyperkube-base image in #57648. **Release note**: ```release-note NONE ``` /assign @tallclair /cc @rphillips @rvkubiak

ivanilves

❤️

ivanilves · 2018-02-14T11:41:49Z

Why can't we just merge this awesome PR? 😇

christianhuening · 2018-02-21T09:56:00Z

Yeah please merge that. We need LGTM on this one! @jbeda ?

cblecker · 2018-02-21T15:12:28Z

/hold

Fsero · 2018-02-21T15:33:15Z

@ixdy sorry it went under my radar, i've just updated it

cblecker · 2018-02-21T15:35:36Z

/hold cancel
/lgtm
/approve

ixdy · 2018-02-21T16:32:47Z

perfect, thanks!
/lgtm

k8s-ci-robot · 2018-02-21T16:32:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, Fsero, gyliu513, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~build/OWNERS~~ [cblecker,ixdy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-github-robot · 2018-02-21T18:57:36Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2018-02-21T19:42:41Z

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

ixdy · 2018-03-28T18:10:26Z

I think in one of the rebases this missed an update to cluster/images/hyperkube/Makefile, so none of the official releases (e.g. 1.10.0) are using this yet. We can cherrypick a fix to 1.10 if we want to fix this for 1.10.1.

rphillips · 2018-03-28T21:12:21Z

Got a cherry pick up for 1.10 #61861

k8s-github-robot assigned cblecker and jbeda Dec 27, 2017

Fsero changed the title ~~Add ipset binary for IPVS, context: https://github.com/kubernetes/kub…~~ Add ipset binary for IPVS, context: Fixes #57321 Dec 27, 2017

Fsero changed the base branch from master to release-1.9 December 27, 2017 10:48

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 27, 2017

Fsero changed the base branch from release-1.9 to master December 27, 2017 10:49

k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 27, 2017

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 27, 2017

Fsero force-pushed the bugfix/add_ipset_binary_for_ipvs branch from 76daecc to bb91e08 Compare December 27, 2017 19:27

Fsero force-pushed the bugfix/add_ipset_binary_for_ipvs branch from bb91e08 to bc6b0de Compare December 27, 2017 21:06

Add ipset binary for IPVS, context: kubernetes#57321

6fd8903

Fsero force-pushed the bugfix/add_ipset_binary_for_ipvs branch from bc6b0de to 6fd8903 Compare February 11, 2018 12:39

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2018

ixdy mentioned this pull request Feb 12, 2018

bazel: update digests for debian-iptables-amd64 and busybox #59772

Merged

ivanilves approved these changes Feb 14, 2018

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2018

adding new tag bumping SHA

882ca30

k8s-github-robot merged commit 8712ed3 into kubernetes:master Feb 21, 2018

jpiper mentioned this pull request Feb 25, 2018

IPset missing from gcr.io/google_containers/hyperkube-amd64 #57321

Closed

ixdy mentioned this pull request Mar 28, 2018

add udev to hyperkube and bump versions #61357

Merged

chenchun mentioned this pull request May 31, 2019

native netlink socket ipset util #78560

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ipset binary for IPVS, context: Fixes #57321 #57648

Add ipset binary for IPVS, context: Fixes #57321 #57648

Fsero commented Dec 27, 2017 •

edited by ixdy

Loading

k8s-ci-robot commented Dec 27, 2017

dims commented Dec 27, 2017

cblecker commented Dec 27, 2017

Fsero commented Dec 27, 2017

Fsero commented Dec 27, 2017

cblecker commented Dec 27, 2017

Fsero commented Dec 27, 2017

Fsero commented Dec 27, 2017

cblecker commented Feb 12, 2018

ixdy commented Feb 12, 2018

ixdy commented Feb 13, 2018

ixdy commented Feb 13, 2018

ivanilves left a comment

ivanilves commented Feb 14, 2018

christianhuening commented Feb 21, 2018 •

edited

Loading

cblecker commented Feb 21, 2018

Fsero commented Feb 21, 2018

cblecker commented Feb 21, 2018

ixdy commented Feb 21, 2018

k8s-ci-robot commented Feb 21, 2018

k8s-github-robot commented Feb 21, 2018

k8s-github-robot commented Feb 21, 2018

ixdy commented Mar 28, 2018

rphillips commented Mar 28, 2018

Add ipset binary for IPVS, context: Fixes #57321 #57648

Add ipset binary for IPVS, context: Fixes #57321 #57648

Conversation

Fsero commented Dec 27, 2017 • edited by ixdy Loading

k8s-ci-robot commented Dec 27, 2017

dims commented Dec 27, 2017

cblecker commented Dec 27, 2017

Fsero commented Dec 27, 2017

Fsero commented Dec 27, 2017

cblecker commented Dec 27, 2017

Fsero commented Dec 27, 2017

Fsero commented Dec 27, 2017

cblecker commented Feb 12, 2018

ixdy commented Feb 12, 2018

ixdy commented Feb 13, 2018

ixdy commented Feb 13, 2018

ivanilves left a comment

Choose a reason for hiding this comment

ivanilves commented Feb 14, 2018

christianhuening commented Feb 21, 2018 • edited Loading

cblecker commented Feb 21, 2018

Fsero commented Feb 21, 2018

cblecker commented Feb 21, 2018

ixdy commented Feb 21, 2018

k8s-ci-robot commented Feb 21, 2018

k8s-github-robot commented Feb 21, 2018

k8s-github-robot commented Feb 21, 2018

ixdy commented Mar 28, 2018

rphillips commented Mar 28, 2018

Fsero commented Dec 27, 2017 •

edited by ixdy

Loading

christianhuening commented Feb 21, 2018 •

edited

Loading