-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support cross resource group for azure file #68117
support cross resource group for azure file #68117
Conversation
fix test failure
a3b5b3e
to
4e3b4a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Could you also add comment on
|
/milestone v1.12 |
It's done, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, feiskyer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Automatic merge from submit-queue (batch tested with PRs 68051, 68130, 67211, 68065, 68117). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md. |
/lgtm |
…8117-upstream-release-1.9 Automated cherry pick of #68117: support cross resource group for azure file
…8117-upstream-release-1.11 Automated cherry pick of #68117: support cross resource group for azure file
What this PR does / why we need it:
support cross resource group for azure file: by
resourceGroup
field, azure cloud provider will create azure file on user specified resource groupWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #64428
Special notes for your reviewer:
Release note:
/kind bug
/sig azure
/assign @feiskyer
cd @khenidak