Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support cross resource group for azure file #68117

Merged
merged 1 commit into from
Aug 31, 2018

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 31, 2018

What this PR does / why we need it:
support cross resource group for azure file: by resourceGroup field, azure cloud provider will create azure file on user specified resource group

---
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: azurefile-rg
provisioner: kubernetes.io/azure-file
parameters:
  resourceGroup: RESOURCE_GROUP_NAME
  storageAccount: EXISTING_STORAGE_ACCOUNT

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #64428

Special notes for your reviewer:

Release note:

resourcegroup parameter is added to AzureFile storage class to support azure file dyanmic provision in cross resource group.

/kind bug
/sig azure
/assign @feiskyer
cd @khenidak

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/azure cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Aug 31, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 31, 2018
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@feiskyer
Copy link
Member

Could you also add comment on resourcegroup parameter in release note? e.g.

resourcegroup parameter is added to AzureFile storage class to support azure files in cross resource groups.

@feiskyer
Copy link
Member

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Aug 31, 2018
@andyzhangx
Copy link
Member Author

Could you also add comment on resourcegroup parameter in release note

It's done, thanks.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 31, 2018
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 68051, 68130, 67211, 68065, 68117). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit e1a270d into kubernetes:master Aug 31, 2018
k8s-github-robot pushed a commit that referenced this pull request Sep 6, 2018
…8117-upstream-release-1.10

Automatic merge from submit-queue.

Automated cherry pick of #68117: support cross resource group for azure file

Cherry pick of #68117 on release-1.10.

#68117: support cross resource group for azure file
@brendandburns
Copy link
Contributor

/lgtm
/approve

k8s-ci-robot added a commit that referenced this pull request Sep 18, 2018
…8117-upstream-release-1.9

Automated cherry pick of #68117: support cross resource group for azure file
k8s-ci-robot added a commit that referenced this pull request Oct 19, 2018
…8117-upstream-release-1.11

Automated cherry pick of #68117: support cross resource group for azure file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

specify resource group for azure file PVC dynamic creation
5 participants