Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to golang 1.10.4 #68802

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Update to golang 1.10.4 #68802

merged 1 commit into from
Sep 20, 2018

Conversation

ixdy
Copy link
Member

@ixdy ixdy commented Sep 18, 2018

What this PR does / why we need it: updates the build to use golang 1.10.4. There are a few compiler fixes as noted in https://github.com/golang/go/issues?q=milestone%3AGo1.10.4

It's pretty late in the k8s 1.12 release cycle, so we might want to wait till 1.12.1 for this? I'm not sure how critical the fixes are.

Release note:

Update to golang 1.10.4

/sig release
/hold
because kube-cross isn't published yet

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. sig/release Categorizes an issue or PR as relevant to SIG Release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 18, 2018
@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 18, 2018
@tpepper
Copy link
Member

tpepper commented Sep 18, 2018

Given we've just announced delay of the release, I'm somewhat willing to entertain accepting this for 1.12 ASAP. We have 9 days.

@ixdy
Copy link
Member Author

ixdy commented Sep 18, 2018

/assign @cblecker @BenTheElder

@ixdy
Copy link
Member Author

ixdy commented Sep 18, 2018

What kind even applies to this PR? cleanup?

@tpepper
Copy link
Member

tpepper commented Sep 18, 2018

If we had test automation comparing our core components and dependencies used versions versus the corresponding upstream latest patch versions...this would be kind failing-test :)

@neolit123
Copy link
Member

neolit123 commented Sep 18, 2018 •
edited
Loading

k/k needs more kinds for sure.

e.g. kind/upgrade ?
area/build-system

@tpepper
Copy link
Member

tpepper commented Sep 18, 2018

pull-kubernetes-cross failure looks legit @ixdy ?

@ixdy
Copy link
Member Author

ixdy commented Sep 18, 2018

yeah, that failure is expected until kube-cross gets published. (working on that.)

@ixdy
Copy link
Member Author

ixdy commented Sep 18, 2018

/retest
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 18, 2018
@ixdy
Copy link
Member Author

ixdy commented Sep 18, 2018

ok, that retest was a little jumpy, since the image hasn't been published yet.

@ixdy
Copy link
Member Author

ixdy commented Sep 18, 2018

/retest

@neolit123
Copy link
Member

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Sep 19, 2018
@cblecker
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 19, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, ixdy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@amwat amwat mentioned this pull request Sep 19, 2018
Merged
@nikhita nikhita mentioned this pull request Sep 19, 2018
Merged
@tpepper
Copy link
Member

tpepper commented Sep 19, 2018

I'm a bit worried by the size of storage merge for v1.12 today. I want to see the test results there still showing ok this morning, and then intend to unhold this PR this afternoon. Need the team to watch test results especially closely for a good 72hrs after this as it may have not just simpler immediate master branch and quickly following release-1.12 branch issues, but long running scalability issues.

/cc @wojtek-t @shyamjvs

@tpepper
Copy link
Member

tpepper commented Sep 19, 2018

Here we go...no reason to expect issues but arrrr hands on deck me k8s maties

/kind critical-urgent
/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 19, 2018
@tpepper
Copy link
Member

tpepper commented Sep 19, 2018

Argh
/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 19, 2018
@BenTheElder
Copy link
Member

/retest

2 similar comments
@BenTheElder
Copy link
Member

/retest

@BenTheElder
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit f6d8fd8 into kubernetes:master Sep 20, 2018
@mfranczy mfranczy mentioned this pull request Jan 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@mkumatag mkumatag Awaiting requested review from mkumatag

@shyamjvs shyamjvs Awaiting requested review from shyamjvs

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@BenTheElder BenTheElder

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.
6 participants
@ixdy @tpepper @neolit123 @cblecker @k8s-ci-robot @BenTheElder