Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: graduate etcd phase #70388

Merged
merged 2 commits into from
Nov 1, 2018
Merged

kubeadm: graduate etcd phase #70388

merged 2 commits into from
Nov 1, 2018

Conversation

neolit123
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:

move the etcd phase to phase runner.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Refs kubernetes/kubeadm#1163

Special notes for your reviewer:
NONE

Does this PR introduce a user-facing change?:

NONE

/assign @fabriziopandini
@kubernetes/sig-cluster-lifecycle-pr-reviews
/kind feature
/area kubeadm
/hold

depends on:
#70331
#70098
#70097

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. kind/feature Categorizes issue or PR as related to a new feature. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 29, 2018
@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Oct 29, 2018
@neolit123
Copy link
Member Author

@fabriziopandini
this preserved local etcd as a sub-phase. please let me know if it needs restructure.

@neolit123 neolit123 mentioned this pull request Oct 29, 2018
Closed
17 tasks
fabriziopandini
fabriziopandini approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neolit123 well done.
Poke me when all the precedence are merged for a final pass

cmd/kubeadm/app/cmd/phases/etcd.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/cmd/phases/etcd.go Outdated Show resolved Hide resolved
cmd/kubeadm/app/cmd/phases/etcd.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2018
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 31, 2018
@neolit123
Copy link
Member Author

@fabriziopandini updated + rebased.

fabriziopandini
fabriziopandini approved these changes Oct 31, 2018
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neolit123 Great!
/approve
/lgtm

cmd/kubeadm/app/cmd/phases/etcd.go
Short: "Generates static Pod manifest file for local/stacked etcd.",
Example: etcdLocalExample,
Phases: []workflow.Phase{
newEtcdLocalSubPhase(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might be a phase with only a subphase is kind of verbose, but I'm fine with this for now...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, also @timothysc for feedback on this.
LMK if you want to refactor "etcd" into a parent phase that implies "local etcd" only.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this for now.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 31, 2018
@neolit123 neolit123 changed the title [WIP] kubeadm: graduate etcd phase kubeadm: graduate etcd phase Oct 31, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 31, 2018
@neolit123 neolit123 mentioned this pull request Nov 1, 2018
Merged
timothysc
timothysc suggested changes Nov 1, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove all the references to "stacked" then LGTM
/approve
/hold cancel

cmd/kubeadm/app/cmd/phases/etcd.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 1, 2018
@timothysc timothysc added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: fabriziopandini, neolit123, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2018
@fabriziopandini
Copy link
Member

/test pull-kubernetes-e2e-gce-100-performance
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2018
timothysc
timothysc approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit 78b43cc into kubernetes:master Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timothysc timothysc timothysc approved these changes

@fabriziopandini fabriziopandini fabriziopandini approved these changes

Assignees

@timothysc timothysc

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@neolit123 @k8s-ci-robot @fabriziopandini @timothysc