Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSI Kubelet Plugin Watcher DeRegistration #70548

Merged
merged 1 commit into from
Nov 2, 2018
Merged

CSI Kubelet Plugin Watcher DeRegistration #70548

merged 1 commit into from
Nov 2, 2018

Conversation

vladimirvivien
Copy link
Member

What type of PR is this?

/kind bug

What this PR does / why we need it:
This PR implements code to deregister CSI plugin when Kubelet Plugin Watcher RegistrationHandler.DeRegister method is called.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #70103

Does this PR introduce a user-facing change?:
NONE

NONE

/sig storage

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 1, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2018
@vladimirvivien vladimirvivien changed the title CSI Kubelet Plugin Watcher unregistration CSI Kubelet Plugin Watcher DeRegistration Nov 1, 2018
@davidz627
Copy link
Contributor

This has slight overlap with #70515, but I can just rebase when this goes in, looks like you've done a more thorough job with error handling

@jsafrane
Copy link
Member

jsafrane commented Nov 2, 2018

/kind cleanup
/lgtm

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 2, 2018
@k8s-ci-robot k8s-ci-robot merged commit 6c0684f into kubernetes:master Nov 2, 2018
@msau42 msau42 mentioned this pull request Nov 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidz627 davidz627 Awaiting requested review from davidz627

@saad-ali saad-ali Awaiting requested review from saad-ali

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSI - kubelet plugin watcher DeRegister method implementation
4 participants
@vladimirvivien @k8s-ci-robot @davidz627 @jsafrane