Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iptables reset text message #70874

Merged
merged 1 commit into from
Nov 14, 2018
Merged

iptables reset text message #70874

merged 1 commit into from
Nov 14, 2018

Conversation

rdodev
Copy link
Contributor

@rdodev rdodev commented Nov 9, 2018

Signed-off-by: Ruben Orduz rubenoz@gmail.com

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
Presently kubeadm reset does not delete or clean up iptables rules. The way components are separated and decoupled makes a programmatic solution rather cumbersome. Thus, it was agreed to expand the reset console output to include instructions how a user might want to reset their iptables.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #689

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
YES
-->

`kubeadm reset` now outputs instructions about manual iptables rules cleanup.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. kind/bug Categorizes issue or PR as related to a bug. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 9, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @rdodev. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 9, 2018
@xmudrii
Copy link
Member

xmudrii commented Nov 9, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 9, 2018
@timothysc timothysc added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Nov 9, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Nov 9, 2018
@timothysc
Copy link
Member

/assign @timothysc

timothysc
timothysc suggested changes Nov 9, 2018
View reviewed changes
cmd/kubeadm/app/cmd/reset.go Outdated Show resolved Hide resolved
@timothysc timothysc added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed kind/bug Categorizes issue or PR as related to a bug. labels Nov 9, 2018
@rdodev
Copy link
Contributor Author

rdodev commented Nov 9, 2018

/test pull-kubernetes-e2e-kops-aws

/test pull-kubernetes-e2e-gce-100-performance

@rdodev
Copy link
Contributor Author

rdodev commented Nov 9, 2018

/test pull-kubernetes-e2e-gce-100-performance

@rdodev
Copy link
Contributor Author

rdodev commented Nov 9, 2018

pull-kubernetes-e2e-gce-100-performance

I don't think the failure is related to this PR at all

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2018
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2018
@timothysc timothysc added this to the v1.13 milestone Nov 12, 2018
@rdodev
iptables reset text message
89a5d5c 
Signed-off-by: Ruben Orduz <rubenoz@gmail.com>
@rdodev
Copy link
Contributor Author

rdodev commented Nov 13, 2018

@timothysc can get review resolved /lgtm if you deem it so, when you get a chance?

neolit123
neolit123 reviewed Nov 13, 2018
View reviewed changes
Copy link
Member

@neolit123 neolit123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @rdodev
added one comment about the potential for moving this to the cmd long description.

cmd/kubeadm/app/cmd/reset.go
If your cluster was setup to utilize IPVS, run ipvsadm --clear (or similar)
to reset your system's IPVS tables.
`
fmt.Print(msg)
Copy link
Member

@neolit123 neolit123 Nov 13, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should print this in the cobra commands help screen e.g. kubeadm reset --help instead of printing it on every run.

but i will defer to @timothysc 's decision on this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It only matters when they run the command, so I'm fine with it here. Otherwise it would just be noise in the help window.

timothysc
timothysc approved these changes Nov 13, 2018
View reviewed changes
Copy link
Member

@timothysc timothysc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rdodev, timothysc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2018
@neolit123
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 8d27e56 into kubernetes:master Nov 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neolit123 neolit123 neolit123 left review comments

@justinsb justinsb justinsb left review comments

@timothysc timothysc timothysc approved these changes

@detiber detiber Awaiting requested review from detiber

@kad kad Awaiting requested review from kad

Assignees

@timothysc timothysc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.

Stale iptables rules seen after "kubeadm reset"
6 participants
@rdodev @k8s-ci-robot @xmudrii @timothysc @neolit123 @justinsb