Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eclass task 1: clean up old code #71399

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Eclass task 1: clean up old code #71399

merged 2 commits into from
Dec 18, 2018

Conversation

resouer
Copy link
Contributor

@resouer resouer commented Nov 25, 2018 •
edited
Loading

Long live equivalence class!

Since new design of eclass is out , it's now safe to remove the old eclass related code. Then PRs of new design can follow up.

What type of PR is this?

Uncomment only one, leave it on its own line:

/kind cleanup

What this PR does / why we need it:

Task 1 of #68720

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Fixes #71013

Special notes for your reviewer:

cc @denkensk @Huang-Wei @bsalamat

Marked as WIP since we need to make sure the clean up is complete and tests are happy. Will be ready for review after that.

Does this PR introduce a user-facing change?:

Clean up old eclass code

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 25, 2018
@resouer
Copy link
Contributor Author

resouer commented Nov 25, 2018

/assign @Huang-Wei

@resouer
Copy link
Contributor Author

resouer commented Nov 25, 2018

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Nov 25, 2018
@resouer resouer mentioned this pull request Nov 25, 2018
Closed
@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Nov 25, 2018
@resouer resouer changed the title [WIP] Eclass task 1: clean up old code Eclass task 1: clean up old code Nov 25, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 25, 2018
@k82cn
Copy link
Member

k82cn commented Nov 26, 2018

/approve

lgtm overall :)

Huang-Wei
Huang-Wei approved these changes Nov 26, 2018
View reviewed changes
Copy link
Member

@Huang-Wei Huang-Wei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 26, 2018
@resouer
Copy link
Contributor Author

resouer commented Nov 27, 2018

Thanks! We still need someone from sig-testing to review. Kindly ping @jberkus, any bandwidth?

The deleted e2e tests are not enabled by default, so I think it's quite safe. :-)

@bsalamat bsalamat self-assigned this Nov 30, 2018
@bsalamat
Copy link
Member

@msau42 FYI

bsalamat
bsalamat approved these changes Nov 30, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks, @resouer! There is a small conflict that should be resolved.

@msau42
Copy link
Member

msau42 commented Nov 30, 2018

lgtm!

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 10, 2018
@resouer resouer force-pushed the eclass-task-1 branch 3 times, most recently from a534cda to af44761 Compare December 12, 2018 19:14
@resouer
Copy link
Contributor Author

resouer commented Dec 12, 2018 •
edited
Loading

@bsalamat The PR is rebased frequently these days, maybe you wanna do a final check.

Also, we need someone to approve the change in test, kindly ping @jberkus

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2018
@misterikkit
Copy link

/lgtm
change still looks good. Just needs approval from @kubernetes/sig-testing-pr-reviews

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2018
@ixdy
Copy link
Member

ixdy commented Dec 18, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, ixdy, k82cn, resouer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2018
denkensk and others added 2 commits December 17, 2018 17:05
@denkensk @resouer
Eclass Task 1: clean up old equiv class code
1081e91 
Co-authored-by: Harry Zhang <resouer@gmail.com>
Co-authored-by: Wang Qingcan <wangqingcan@baidu.com>
@resouer
Fixed outdated bazel
797601d
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 18, 2018
@bsalamat
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 18, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit b97092c into kubernetes:master Dec 18, 2018
@misterikkit
Copy link

🎆 🍾
Looking forward to the new design/implementation

@resouer resouer deleted the eclass-task-1 branch December 18, 2018 21:57
@resouer
Copy link
Contributor Author

resouer commented Dec 19, 2018

The new implementation is just by handy, would be out very shortly :-)

This was referenced Dec 20, 2018
Closed
Closed
Closed
@bbarnes52-zz bbarnes52-zz mentioned this pull request Nov 30, 2021
Closed
4 tasks
@lowang-bh lowang-bh mentioned this pull request May 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misterikkit misterikkit misterikkit left review comments

@bsalamat bsalamat bsalamat approved these changes

@Huang-Wei Huang-Wei Huang-Wei approved these changes

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@Huang-Wei Huang-Wei

@misterikkit misterikkit

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove equivalence cache from the scheduler code base
10 participants
@resouer @k82cn @bsalamat @msau42 @misterikkit @ixdy @k8s-ci-robot @fejta-bot @Huang-Wei @denkensk