-
Notifications
You must be signed in to change notification settings - Fork 39.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print additional columns for RuntimeClass CRD #72446
Print additional columns for RuntimeClass CRD #72446
Conversation
/priority important-soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Huang-Wei, tallclair The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice , since what version of kubernetes has this feature been available
/retest |
@krmayankk 1.11, see additional-printer-columns |
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
/retest Review the full test history for this PR. Silence the bot with an |
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
/retest Review the full test history for this PR. Silence the bot with an |
1 similar comment
/retest Review the full test history for this PR. Silence the bot with an |
/lgtm cancel Until gke-e2e is fixed |
/test pull-kubernetes-e2e-gke |
It's weird that the change results in a GKE e2e failure. I looked through the log and it says:
And the specific error says:
@kubernetes/sig-testing Could you give a hand on diagnosing this? Thanks in advance. /sig testing |
@Huang-Wei - it was broken, see run across PRs. |
/retest |
@yastij Thanks! Could you re-label /lgtm? |
/lgtm |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Without this PR, runtimeclass obj is printed with name and age columns:
After leveraging
additionalPrinterColumns
feature of CRD (since 1.11), more meaningful columns can be printed out:Does this PR introduce a user-facing change?:
/sig node
/assign @tallclair