Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated versionless client interface methods #74422

Merged
merged 3 commits into from
Feb 26, 2019
Merged

Remove deprecated versionless client interface methods #74422

merged 3 commits into from
Feb 26, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 22, 2019

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Removes the long-deprecated versionless external client interfaces.

As new versions of API groups are added, the version these accessors targets shifts, which can silently make an application target an unintended version when recompiled with a newer client-go library.

Does this PR introduce a user-facing change?:

client-go: the deprecated versionless API group accessors (like `clientset.Apps()` have been removed). Use an explicit version instead (like `clientset.AppsV1()`)

/sig api-machinery
/cc @sttts @lavalamp

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Feb 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubeadm area/kubectl sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 22, 2019
@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Feb 22, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Feb 22, 2019
@liggitt liggitt force-pushed the client-version-methods branch from f3442cc to 1bfd3cb Compare February 23, 2019 07:19
@yliaog
Copy link
Contributor

yliaog commented Feb 25, 2019

/cc

@k8s-ci-robot k8s-ci-robot requested a review from yliaog February 25, 2019 22:08
@sttts
Copy link
Contributor

sttts commented Feb 26, 2019

/lgtm

This is deprecated for so long. Let's remove it finally 👍

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2019
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@liggitt liggitt force-pushed the client-version-methods branch from 1bfd3cb to d1e865e Compare February 26, 2019 13:38
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2019
@liggitt
Copy link
Member Author

liggitt commented Feb 26, 2019

/retest

@liggitt
Copy link
Member Author

liggitt commented Feb 26, 2019 •
edited
Loading

rebased to fix .Core() reference added in https://github.com/kubernetes/kubernetes/pull/72827/files#diff-02452a489cab3905278eefb9a8e3f4aaR76

retagging

@liggitt
Copy link
Member Author

liggitt commented Feb 26, 2019

/retest

@liggitt liggitt added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit be8a9b9 into kubernetes:master Feb 26, 2019
@liggitt liggitt deleted the client-version-methods branch February 27, 2019 17:59
@liggitt liggitt added this to the v1.14 milestone Jun 10, 2019
@mikkeloscar mikkeloscar mentioned this pull request Jul 15, 2019
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lavalamp lavalamp Awaiting requested review from lavalamp

@sttts sttts Awaiting requested review from sttts

@yliaog yliaog Awaiting requested review from yliaog

Assignees

@sttts sttts

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/code-generation area/kubeadm area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.14
Development

Successfully merging this pull request may close these issues.
5 participants
@liggitt @k8s-ci-robot @yliaog @sttts @fejta-bot