-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix kubeadm init output #75420
fix kubeadm init output #75420
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM found two typo/nits.
thanks.
9855ee2
to
86be7d4
Compare
/test pull-kubernetes-kubemark-e2e-gce-big |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @fabriziopandini
@fabriziopandini Hello! I'd like to remind that the Code Thaw is starting tomorrow, Tuesday PST EOD. Is it possible to get this PR reviewed and approved by then? Otherwise, the PR will have to compete with herd of other incoming PRs post-thaw. |
86be7d4
to
fcadf14
Compare
@xmudrii thanks for the heads up. we are rallying to get this in before code thaw @neolit123 @yagonobre, all the comment are addressed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes a duplicated message in the kubeadm init output (
You can now join any number of machines by running the following on each node as root
repeated twice) and wrong indentation.Additionally, now the join control-plane message is printed only when the preconditions for joining a control plane are satisfied:
kubeadm init output for cluster WITHOUT
controlPlaneEndpoint
--> join control-plane conditions not satisfied:kubeadm init output for cluster WITH
controlPlaneEndpoint
, but created WITHOUT--upload-certs
.... You can now join any number of control-plane node by copying certificate authorities and service account keys on each node and then running the following as root: kubeadm join 172.17.0.2:6443 --token abcdef.0123456789abcdef \ --discovery-token-ca-cert-hash sha256:c2b92b4d0864ed76706f51962ab709f404d58874f8a5b7e7e8aa88fcfe8fc518 \ --experimental-control-plane Then you can join any number of worker nodes by running the following on each as root: kubeadm join 172.17.0.2:6443 --token abcdef.0123456789abcdef \ --discovery-token-ca-cert-hash sha256:c2b92b4d0864ed76706f51962ab709f404d58874f8a5b7e7e8aa88fcfe8fc518
kubeadm init output for cluster WITH
controlPlaneEndpoint
and WITH--upload-certs
Does this PR introduce a user-facing change?:
/sig cluster-lifecycle
/priority critical-urgent
/milestone v1.14
/assign @neolit123
/assign @timothysc
/cc @yagonobre