Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude custom transports when constructing AnonymousClientConfig() #75771

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Exclude custom transports when constructing AnonymousClientConfig() #75771

merged 1 commit into from
Apr 4, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 27, 2019 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
The AnonymousClientConfig() method returns a copy of a rest.Config struct, copying only fields that are known to not contain credentials.

The custom Transport and WrapTransport config fields can be used to inject credentials,
so those should not be included.

Does this PR introduce a user-facing change?:

client-go: The `rest.AnonymousClientConfig(*rest.Config) *rest.Config` helper method no longer copies custom `Transport` and `WrapTransport` fields, because those can be used to inject user credentials.

xref #76797

@liggitt liggitt added kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/client-libraries sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Mar 27, 2019
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Mar 27, 2019
@liggitt liggitt added sig/auth Categorizes an issue or PR as relevant to SIG Auth. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 27, 2019
@liggitt
Copy link
Member Author

liggitt commented Mar 27, 2019

/cc @tallclair

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2019
@liggitt liggitt added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 27, 2019
@liggitt liggitt added this to the v1.15 milestone Mar 27, 2019
@tallclair
Copy link
Member

lgtm

@enj
Copy link
Member

enj commented Apr 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2019
@liggitt liggitt added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 3, 2019
@k8s-ci-robot k8s-ci-robot merged commit fc556f0 into kubernetes:master Apr 4, 2019
@liggitt liggitt deleted the AnonymousClientConfig branch April 4, 2019 13:17
@liggitt liggitt mentioned this pull request Apr 18, 2019
Closed
@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Apr 18, 2019
@k8s-ci-robot k8s-ci-robot removed the release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. label Apr 18, 2019
@mengjiao-liu mengjiao-liu mentioned this pull request Dec 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tallclair tallclair Awaiting requested review from tallclair

@errordeveloper errordeveloper Awaiting requested review from errordeveloper

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@enj enj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/client-libraries cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/auth Categorizes an issue or PR as relevant to SIG Auth. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.15
Development

Successfully merging this pull request may close these issues.
4 participants
@liggitt @k8s-ci-robot @tallclair @enj