kubeadm: fix join control-plane with external-etcd #75847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/M
k8s-ci-robot
added
kind/bug
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
neolit123
reviewed
Mar 28, 2019
There was a problem hiding this comment.
/lgtm
thanks for the quick PR @fabriziopandini
i can send the cherry pick.
|
cherry pick: #75851 |
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 4, 2019
…847-origin-release-1.14 Automated cherry pick of #75847: fix-external-etcd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes preflight checks for
kubeadm join control-planein case of external-etcd/securedWhich issue(s) this PR fixes:
Fixes # kubernetes/kubeadm#1472
Special notes for your reviewer:
This Fix is a candidate for cherry picking in v1.14
Does this PR introduce a user-facing change?:
/sig cluster-lifecycle
/priority critical-urgent
/assign @neolit123 @rosti
/cc @kubernetes/sig-cluster-lifecycle-pr-reviews