Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect prometheus azure metrics #77722

Merged
merged 1 commit into from
May 13, 2019

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented May 10, 2019

What type of PR is this?
/kind bug

What this PR does / why we need it:
Following azure metrics are wrong:

azLoadBalancersClient.CreateOrUpdate: load_balancers_create_or_update
azLoadBalancersClient.Delete: load_balancers_delete
azLoadBalancersClient.Get: public_ip_addresses_create_or_update
azRouteTablesClient.CreateOrUpdate: route_tables_create_or_update
azPublicIPAddressesClient: public_ip_addresses_delete
azVirtualMachineScaleSetVMsClient.Udate: vmssvm_update
azDisksClient.CreateOrUpdate: disks_create_or_update
azDisksClient.Delete: disks_delete

Which issue(s) this PR fixes:

Fixes #77721

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix incorrect prometheus azure metrics

/assign @feiskyer
/priority important-soon
/sig azure

/test pull-kubernetes-e2e-aks-engine-azure

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/azure cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 10, 2019
@k8s-ci-robot k8s-ci-robot added area/cloudprovider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 10, 2019
@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-aks-engine-azure

1 similar comment
@justaugustus
Copy link
Member

/test pull-kubernetes-e2e-aks-engine-azure

@andyzhangx
Copy link
Member Author

/test pull-kubernetes-e2e-aks-engine-azure
@feiskyer PTAL

Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/test

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feiskyer
Copy link
Member

/test pull-kubernetes-e2e-aks-engine-azure

@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-aks-engine-azure a33b86e link /test pull-kubernetes-e2e-aks-engine-azure

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 3bc595e into kubernetes:master May 13, 2019
k8s-ci-robot added a commit that referenced this pull request May 21, 2019
…7722-upstream-release-1.14

Automated cherry pick of #77722: fix incorrect prometheus metrics
k8s-ci-robot added a commit that referenced this pull request May 23, 2019
…7722-upstream-release-1.12

Automated cherry pick of #77722: fix incorrect prometheus metrics
k8s-ci-robot added a commit that referenced this pull request May 31, 2019
…7722-upstream-release-1.13

Automated cherry pick of #77722: fix incorrect prometheus metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cloudprovider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

some azure metrics are wrong
4 participants