-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle updates removing remaining finalizers on deleted objects #77952
Conversation
c8a5399
to
7461b4a
Compare
The approach lgtm. Please add a unit test to ensure the namespace delete behavior is correct. We need to update namespace controller and crd finalizer logic, these lines should be redundant now: kubernetes/pkg/controller/namespace/deletion/namespaced_resources_deleter.go Lines 157 to 159 in aaec77a
kubernetes/staging/src/k8s.io/apiextensions-apiserver/pkg/controller/finalizer/crd_finalizer.go Lines 158 to 159 in aaec77a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
done, added positive and negative unit tests for spec and metadata finalizers on namespace update and finalize storage
added TODOs to remove redundant deletes in the next release (I'd rather be extra sure we don't block namespace or CRD cleanup in a controller/apiserver skew scenario) |
/retest |
/lgtm |
/priority important-soon |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Avoids making all finalizer implementers do a separate delete after removing their finalizer
Which issue(s) this PR fixes:
Fixes #77944
Does this PR introduce a user-facing change?:
/sig api-machinery
/cc @caesarxuchao