job controller support modify sync flag #79264

chengxiangwang · 2019-06-21T05:59:02Z

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

/kind feature

What this PR does / why we need it:
Our team USES batch.Job in large quantities for ai task training, and the number of jobs is about 20w per day. We need to adjust the number of Job controller workers to speed up the processing speed, so we need to expose this parameter
Which issue(s) this PR fixes:

Fixes #
allow the number of job controller workers to be modified.
Special notes for your reviewer:

Does this PR introduce a user-facing change?:

   minor change:
     A larger number means more responsive jobs, but more CPU and network load

k8s-ci-robot · 2019-06-21T05:59:04Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2019-06-21T05:59:09Z

Hi @chengxiangwang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chengxiangwang · 2019-06-21T06:35:47Z

/assign @lavalamp

chengxiangwang · 2019-06-21T06:36:30Z

/approve

chengxiangwang · 2019-06-21T06:37:38Z

/lgtm

k8s-ci-robot · 2019-06-21T06:37:39Z

@chengxiangwang: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

chengxiangwang · 2019-06-21T06:38:39Z

/approve no-issue

k8s-ci-robot · 2019-06-21T06:39:10Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chengxiangwang
To complete the pull request process, please assign lavalamp
You can assign the PR to them by writing /assign @lavalamp in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

cmd/kube-controller-manager/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

neolit123

please include a sentence under the "user facing" part of the OP, that explains the change.
i will defer to api-machinery whether this inclusion makes sense.

neolit123 · 2019-06-22T22:07:14Z

cmd/kube-controller-manager/app/options/jobcontroller.go

@@ -32,6 +32,7 @@ func (o *JobControllerOptions) AddFlags(fs *pflag.FlagSet) {
 	if o == nil {
 		return
 	}
+        fs.Int32Var(&o.ConcurrentJobSyncs, "concurrent-job-syncs", o.ConcurrentJobSyncs,"The number of job objects that are allowed to sync concurrently. Larger number = more responsive jobs, but more CPU (and network) load")


minor change:
A larger number means more responsive jobs, but more CPU and network load

@neolit123 done,thxs

i don't see your update.
did you forget to push?

please use git push -f .... so that this PR only has one commit.

roycaihw · 2019-06-24T21:06:39Z

/sig apps
/remove-sig api-machinery

chengxiangwang · 2019-07-04T09:43:49Z

/approve

chengxiangwang · 2019-07-04T09:44:50Z

/lgtm

k8s-ci-robot · 2019-07-04T09:44:50Z

@chengxiangwang: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

fejta-bot · 2019-10-02T11:54:51Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

quinton-hoole · 2019-10-07T18:01:17Z

/remove-lifecycle stale

quinton-hoole · 2019-10-07T18:04:36Z

/retest

quinton-hoole · 2019-10-07T18:43:32Z

The failure of pull-kubernetes-e2e-gce-100-performance looks like a flake in the test infrastructure, specifically "ERROR: (gcloud.compute.routers.create) Quota 'ROUTERS' exceeded. Limit: 10.0 globally."

It does not appear to have anything to do with this particular PR.

See kubernetes/test-infra#14611 fixed in kubernetes/test-infra#14598 .

W1007 18:20:13.785] Created [https://www.googleapis.com/compute/v1/projects/k8s-presubmit-scale/regions/us-east1/subnetworks/e2e-79264-95a39-custom-subnet].
I1007 18:20:14.001] NAME                           REGION    NETWORK          RANGE
I1007 18:20:14.002] e2e-79264-95a39-custom-subnet  us-east1  e2e-79264-95a39  10.40.0.0/22
I1007 18:20:14.065] Created subnetwork e2e-79264-95a39-custom-subnet
I1007 18:20:14.066] Using subnet e2e-79264-95a39-custom-subnet
W1007 18:20:15.447] Creating router [e2e-79264-95a39-nat-router]...
W1007 18:20:19.703] ......................failed.
W1007 18:20:19.869] ERROR: (gcloud.compute.routers.create) Quota 'ROUTERS' exceeded.  Limit: 10.0 globally.
W1007 18:20:19.948] 2019/10/07 18:20:19 process.go:155: Step './hack/e2e-internal/e2e-up.sh' finished in 1m41.565428081s
W1007 18:20:19.948] 2019/10/07 18:20:19 e2e.go:519: Dumping logs from nodes to GCS directly at path: gs://kubernetes-jenkins/pr-logs/pull/79264/pull-kubernetes-e2e-gce-100-performance/1181269224534839296/artifacts
W1007 18:20:19.948] 2019/10/07 18:20:19 process.go:153: Running: ./cluster/log-dump/log-dump.sh /workspace/_artifacts gs://kubernetes-jenkins/pr-logs/pull/79264/pull-kubernetes-e2e-gce-100-performance/1181269224534839296/artifacts
W1007 18:20:20.019] Trying to find master named 'e2e-79264-95a39-master'
W1007 18:20:20.019] Looking for address 'e2e-79264-95a39-master-ip'
I1007 18:20:20.120] Checking for custom logdump instances, if any
I1007 18:20:20.120] Sourcing kube-util.sh
I1007 18:20:20.121] Detecting project
I1007 18:20:20.121] Project: k8s-presubmit-scale
I1007 18:20:20.121] Network Project: k8s-presubmit-scale
I1007 18:20:20.121] Zone: us-east1-b
I1007 18:20:20.121] Dumping logs from master locally to '/workspace/_artifacts'
W1007 18:20:20.751] ERROR: (gcloud.compute.addresses.describe) Could not fetch resource:
W1007 18:20:20.752]  - The resource 'projects/k8s-presubmit-scale/regions/us-east1/addresses/e2e-79264-95a39-master-ip' was not found

quinton-hoole · 2019-10-08T01:01:27Z

/retest

quinton-hoole · 2019-10-08T17:54:37Z

Sounds like the underlying quota issue has been fixed:

#83493 (comment)

/retest

k8s-ci-robot · 2019-10-08T18:53:20Z

@chengxiangwang: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-kubernetes-verify	`9b643eb`	link	`/test pull-kubernetes-verify`
pull-kubernetes-e2e-gce	`9b643eb`	link	`/test pull-kubernetes-e2e-gce`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

fejta-bot · 2020-01-06T19:32:51Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

fejta-bot · 2020-02-05T20:15:36Z

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

fejta-bot · 2020-03-06T20:57:27Z

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

k8s-ci-robot · 2020-03-06T20:57:35Z

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

job controller support modify sync flag

9b643eb

k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2019

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 21, 2019

k8s-ci-robot requested review from janetkuo and quinton-hoole June 21, 2019 06:00

k8s-ci-robot assigned lavalamp Jun 21, 2019

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 21, 2019

neolit123 reviewed Jun 22, 2019

View reviewed changes

k8s-ci-robot added sig/apps Categorizes an issue or PR as relevant to SIG Apps. and removed sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jun 24, 2019

k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 4, 2019

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 2, 2019

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 7, 2019

quinton-hoole mentioned this pull request Oct 7, 2019

pull-kubernetes-e2e-gce-100-performance fails #83493

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2020

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 5, 2020

k8s-ci-robot closed this Mar 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

job controller support modify sync flag #79264

job controller support modify sync flag #79264

chengxiangwang commented Jun 21, 2019 •

edited

Loading

k8s-ci-robot commented Jun 21, 2019

k8s-ci-robot commented Jun 21, 2019

chengxiangwang commented Jun 21, 2019

chengxiangwang commented Jun 21, 2019

chengxiangwang commented Jun 21, 2019

k8s-ci-robot commented Jun 21, 2019

chengxiangwang commented Jun 21, 2019

k8s-ci-robot commented Jun 21, 2019

neolit123 left a comment

neolit123 Jun 22, 2019

chengxiangwang Jul 4, 2019 •

edited

Loading

neolit123 Jul 4, 2019 •

edited

Loading

roycaihw commented Jun 24, 2019

chengxiangwang commented Jul 4, 2019

chengxiangwang commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

fejta-bot commented Oct 2, 2019

quinton-hoole commented Oct 7, 2019

quinton-hoole commented Oct 7, 2019

quinton-hoole commented Oct 7, 2019 •

edited

Loading

quinton-hoole commented Oct 8, 2019

quinton-hoole commented Oct 8, 2019 •

edited

Loading

k8s-ci-robot commented Oct 8, 2019 •

edited

Loading

fejta-bot commented Jan 6, 2020

fejta-bot commented Feb 5, 2020

fejta-bot commented Mar 6, 2020

k8s-ci-robot commented Mar 6, 2020

job controller support modify sync flag #79264

job controller support modify sync flag #79264

Conversation

chengxiangwang commented Jun 21, 2019 • edited Loading

k8s-ci-robot commented Jun 21, 2019

k8s-ci-robot commented Jun 21, 2019

chengxiangwang commented Jun 21, 2019

chengxiangwang commented Jun 21, 2019

chengxiangwang commented Jun 21, 2019

k8s-ci-robot commented Jun 21, 2019

chengxiangwang commented Jun 21, 2019

k8s-ci-robot commented Jun 21, 2019

neolit123 left a comment

Choose a reason for hiding this comment

neolit123 Jun 22, 2019

Choose a reason for hiding this comment

chengxiangwang Jul 4, 2019 • edited Loading

Choose a reason for hiding this comment

neolit123 Jul 4, 2019 • edited Loading

Choose a reason for hiding this comment

roycaihw commented Jun 24, 2019

chengxiangwang commented Jul 4, 2019

chengxiangwang commented Jul 4, 2019

k8s-ci-robot commented Jul 4, 2019

fejta-bot commented Oct 2, 2019

quinton-hoole commented Oct 7, 2019

quinton-hoole commented Oct 7, 2019

quinton-hoole commented Oct 7, 2019 • edited Loading

quinton-hoole commented Oct 8, 2019

quinton-hoole commented Oct 8, 2019 • edited Loading

k8s-ci-robot commented Oct 8, 2019 • edited Loading

fejta-bot commented Jan 6, 2020

fejta-bot commented Feb 5, 2020

fejta-bot commented Mar 6, 2020

k8s-ci-robot commented Mar 6, 2020

chengxiangwang commented Jun 21, 2019 •

edited

Loading

chengxiangwang Jul 4, 2019 •

edited

Loading

neolit123 Jul 4, 2019 •

edited

Loading

quinton-hoole commented Oct 7, 2019 •

edited

Loading

quinton-hoole commented Oct 8, 2019 •

edited

Loading

k8s-ci-robot commented Oct 8, 2019 •

edited

Loading