Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove github.com/kardianos/osext #80142

Merged
merged 1 commit into from
Jul 16, 2019
Merged

remove github.com/kardianos/osext #80142

merged 1 commit into from
Jul 16, 2019

Conversation

rusik69
Copy link
Contributor

@rusik69 rusik69 commented Jul 14, 2019 •
edited
Loading

/kind cleanup

What this PR does / why we need it:
This PR removes deprecated dependency github.com/kardianos/osext
Which issue(s) this PR fixes:

Fixes #80127

Special notes for your reviewer:

Does this PR introduce a user-facing change?:
NONE

Remove deprecated github.com/kardianos/osext dependency

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 14, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @Loqutus. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/dependency Issues or PRs related to dependency changes area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2019
@k8s-ci-robot k8s-ci-robot requested review from thockin, tmrts and a team July 14, 2019 15:41
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 14, 2019
@rusik69
Copy link
Contributor Author

rusik69 commented Jul 14, 2019

/assign @thockin

@dims
Copy link
Member

dims commented Jul 14, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 14, 2019
@rusik69
Copy link
Contributor Author

rusik69 commented Jul 14, 2019

/retest

BenTheElder
BenTheElder reviewed Jul 14, 2019
View reviewed changes
test/e2e_node/e2e_node_suite_test.go Outdated
@@ -45,8 +45,6 @@ import (
"k8s.io/kubernetes/test/e2e/framework/testfiles"
"k8s.io/kubernetes/test/e2e/generated"
"k8s.io/kubernetes/test/e2e_node/services"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this blank line sepetating groups of imports requires the imports to be sorted, which fails gofmt.

We should leave this line.

@BenTheElder
Copy link
Member

Please run hack/update-vendor.sh, removing this dependency should also remove it from vendor.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 14, 2019
@rusik69
Copy link
Contributor Author

rusik69 commented Jul 14, 2019

/retest

@cblecker
Copy link
Member

@Loqutus LGTM, but please squash your commits.

@cblecker
Copy link
Member

/assign

draveness
draveness reviewed Jul 15, 2019
View reviewed changes
Copy link
Contributor

@draveness draveness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 15, 2019
@rusik69
Copy link
Contributor Author

rusik69 commented Jul 15, 2019

@cblecker squashed

@cblecker
Copy link
Member

/lgtm
/approve

/unassign thockin
/assign @liggitt
(Tim is on vacation)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2019
@dims
Copy link
Member

dims commented Jul 16, 2019

👍

@liggitt
Copy link
Member

liggitt commented Jul 16, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, liggitt, loqutus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit fe04041 into kubernetes:master Jul 16, 2019
@liggitt liggitt added this to the v1.16 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenTheElder BenTheElder BenTheElder left review comments

@draveness draveness draveness left review comments

@thockin thockin Awaiting requested review from thockin

@tmrts tmrts Awaiting requested review from tmrts

Assignees

@liggitt liggitt

@cblecker cblecker

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.

github.com/kardianos/osext is deprecated
8 participants
@rusik69 @k8s-ci-robot @dims @BenTheElder @cblecker @liggitt @draveness @thockin