Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove heapster support for kubectl #87498

Merged
merged 1 commit into from
Mar 24, 2020
Merged

Remove heapster support for kubectl #87498

merged 1 commit into from
Mar 24, 2020

Conversation

serathius
Copy link
Contributor

@serathius serathius commented Jan 23, 2020 •
edited
Loading

Heapster is already retired

/kind cleanup

What this PR does / why we need it:
Having kubectl top mention Heapster is confusing for users

Which issue(s) this PR fixes:

Fixes kubernetes/kubectl#806

Special notes for your reviewer:

Deprecate kubectl top flags related to heapster
Drop support of heapster in kubectl top

/cc @brancz

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubectl sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 23, 2020
@brancz
Copy link
Member

brancz commented Jan 23, 2020

I think heapster’s deprecation time is crucial here. What kube release timeframe did we deprecate heapster? As it has to be at least 4 releases ago I believe. I believe it was much longer ago but I just want to double check.

@brancz
Copy link
Member

brancz commented Jan 23, 2020

I just double checked, it was deprecated in 1.11 and removal was actually already planned for 1.13, so we’re good here.

https://github.com/kubernetes-retired/heapster/blob/master/docs/deprecation.md

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2020
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2020
@serathius
Copy link
Contributor Author

/retest

@serathius
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@serathius
Copy link
Contributor Author

/retest

@serathius
Copy link
Contributor Author

/assign @brendandburns

@serathius
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 12, 2020
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Feb 24, 2020
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 24, 2020
@serathius serathius force-pushed the drop-heapster branch 2 times, most recently from ec6b679 to 60ce13c Compare February 24, 2020 23:49
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 24, 2020
@serathius
Deprecate heapster related kubelet flags and remove their implementation
6d9fbd2 
Heapster is retired since 1.11.
Having kubectl top mention Heapster is confusing for users.
@serathius
Copy link
Contributor Author

/retest

3 similar comments
@serathius
Copy link
Contributor Author

/retest

@serathius
Copy link
Contributor Author

/retest

@serathius
Copy link
Contributor Author

/retest

@serathius
Copy link
Contributor Author

@soltysh ping

soltysh
soltysh approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/priority backlog

@k8s-ci-robot k8s-ci-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 24, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2020
@soltysh
Copy link
Contributor

soltysh commented Mar 24, 2020

@soltysh ping

Thanks @serathius and sorry for the delay!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, serathius, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit d3c3907 into kubernetes:master Mar 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 24, 2020
@eddiezane eddiezane mentioned this pull request Jun 24, 2020
Closed
@serathius serathius deleted the drop-heapster branch July 11, 2020 12:06
This was referenced Jan 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@brancz brancz Awaiting requested review from brancz

Assignees

@soltysh soltysh

@brancz brancz

@brendandburns brendandburns

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Drop heapster support in kubectl top
5 participants
@serathius @brancz @soltysh @k8s-ci-robot @brendandburns