-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubeadm: add missing RBAC for getting nodes on "upgrade apply" #89537
kubeadm: add missing RBAC for getting nodes on "upgrade apply" #89537
Conversation
b117a92 added a new check during "join" whether a Node with the same name exists in the cluster. When upgrading from 1.17 to 1.18 make sure the required RBAC by this check is added. Otherwise "kubeadm join" will complain that it lacks permissions to GET a Node.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neolit123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@kubernetes/sig-cluster-lifecycle-pr-reviews |
/lgtm |
/retest |
/retest Review the full test history for this PR. Silence the bot with an |
…537-origin-release-1.18 Automated cherry pick of #89537: kubeadm: add missing RBAC for getting nodes on "upgrade
Hello @neolit123 Thanks for this fix. We just had the issue in our 1.17 => 1.18 upgrade : is the fix only for 1.19 kubeadm version (I see "1.19 milestone") or can it be backport to previous versions too please ? |
@neolit123 oh ok. In our case, we faced the issue when using kubeadm 1.18 to upgrade a 1.17 cluster to 1.18 so you say it is normal because the fix was in 1.18 and 1.19 right ? |
you may have used the |
What this PR does / why we need it:
b117a92 added a new check during "join" whether a Node with
the same name exists in the cluster.
When upgrading from 1.17 to 1.18 make sure the required RBAC
by this check is added. Otherwise "kubeadm join" will complain that
it lacks permissions to GET a Node.
Which issue(s) this PR fixes:
Refs kubernetes/kubeadm#2079
Special notes for your reviewer:
NONE
Does this PR introduce a user-facing change?:
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
/assign @rosti @randomvariable
/priority critical-urgent
/kind bug