-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cpu resource metric type by changing to counter #89540
Conversation
/priority critical-urgent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I'm the guys who omitted the |
/lgtm I think we are now in consensus @dashpole, I think you can now feel free to remove the hold label. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, dashpole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/test pull-kubernetes-e2e-gce |
1 similar comment
/test pull-kubernetes-e2e-gce |
/retest Review the full test history for this PR. Silence the bot with an |
…40-upstream-release-1.18 Automated cherry pick of #89540: fix cpu resource metric type by changing to counter
What type of PR is this?
/kind bug
What this PR does / why we need it:
CPU metrics should be counters, not gauges. When I initially created the kubelet resource metrics endpoint in #73946, I mistakenly made CPU metrics a gauge. When this was refactored to make use of the metrics stability framework in #86282, the cpu metrics were renamed to omit the
_total
suffix, which caught the attention of some sig instrumentation members.Since the endpoint was newly added in 1.18, we have decided to just fix the metric without a deprecation period, and cherry-pick the fix back to the 1.18 release.
Does this PR introduce a user-facing change?:
/assign @brancz @logicalhan @serathius @ehashman
/hold
to make sure we are all in agreement about this change
cc @kubernetes/sig-instrumentation-bugs