Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic on /readyz #93600

Merged
merged 1 commit into from
Aug 3, 2020
Merged

Fix panic on /readyz #93600

merged 1 commit into from
Aug 3, 2020
+53 −8

Conversation

ialidzhikov
Copy link
Contributor

What type of PR is this?
/kind bug
/kind regression

What this PR does / why we need it:
Fix /readyz panic caused by assignment to entry in nil map.

Which issue(s) this PR fixes:

Fixes #93599

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

A panic in the apiserver caused by the `informer-sync` health checker is now fixed.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

NONE

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 31, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ialidzhikov. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 31, 2020
@k8s-ci-robot k8s-ci-robot requested review from jpbetz and wojtek-t July 31, 2020 11:34
@k8s-ci-robot k8s-ci-robot added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 31, 2020
@ialidzhikov
Copy link
Contributor Author

/assign @wojtek-t

@ialidzhikov
Copy link
Contributor Author

/assign @lavalamp

@ialidzhikov
Copy link
Contributor Author

/priority important-soon

@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 31, 2020
timebertt
timebertt reviewed Jul 31, 2020
View reviewed changes
Copy link
Contributor

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@timebertt: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ialidzhikov ialidzhikov requested a review from SataQiu July 31, 2020 14:54
vpnachev
vpnachev approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@vpnachev vpnachev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@vpnachev: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from mborsz July 31, 2020 16:08
@ialidzhikov
Copy link
Contributor Author

Could someone assist with /ok-to-test?

@logicalhan
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 31, 2020
@ialidzhikov
Copy link
Contributor Author

/retest

@ialidzhikov
Fix panic on /readyz
1f06c88 
Signed-off-by: ialidzhikov <i.alidjikov@gmail.com>
@ialidzhikov
Copy link
Contributor Author

ialidzhikov commented Aug 1, 2020 •
edited
Loading

I had to run ./hack/update-gofmt.sh. 😅

@ialidzhikov
Copy link
Contributor Author

/retest

1 similar comment
@logicalhan
Copy link
Member

/retest

@liggitt
Copy link
Member

liggitt commented Aug 1, 2020

verify is failing on #93623, wait until that is resolved to retest

@liggitt
Copy link
Member

liggitt commented Aug 1, 2020

/retest

@liggitt liggitt added priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Aug 3, 2020
SataQiu
SataQiu reviewed Aug 3, 2020
View reviewed changes
Copy link
Member

@SataQiu SataQiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 3, 2020
@wojtek-t
Copy link
Member

wojtek-t commented Aug 3, 2020

Thanks a lot for fixing this!
FTR - this has to be cherrypicked too: #93599 (comment)

@wojtek-t
Copy link
Member

wojtek-t commented Aug 3, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020
@k8s-ci-robot k8s-ci-robot merged commit ec560b9 into kubernetes:master Aug 3, 2020
This was referenced Aug 3, 2020
Merged
Merged
Merged
k8s-ci-robot added a commit that referenced this pull request Aug 4, 2020
@k8s-ci-robot
Merge pull request #93642 from ialidzhikov/automated-cherry-pick-of-#…
a2ed724 
…93600-upstream-release-1.18

Automated cherry pick of #93600: Fix panic on /readyz
k8s-ci-robot added a commit that referenced this pull request Aug 4, 2020
@k8s-ci-robot
Merge pull request #93643 from ialidzhikov/automated-cherry-pick-of-#…
1033539 
…93600-upstream-release-1.17

Automated cherry pick of #93600: Fix panic on /readyz
k8s-ci-robot added a commit that referenced this pull request Aug 4, 2020
@k8s-ci-robot
Merge pull request #93645 from ialidzhikov/automated-cherry-pick-of-#…
b7d3042 
…93600-upstream-release-1.16

Automated cherry pick of #93600: Fix panic on /readyz
@github-actions github-actions bot mentioned this pull request Aug 5, 2020
Open
@ialidzhikov ialidzhikov deleted the fix/readyz-panic branch August 30, 2020 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt left review comments

@SataQiu SataQiu SataQiu left review comments

@vpnachev vpnachev vpnachev approved these changes

@jpbetz jpbetz Awaiting requested review from jpbetz

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

@mborsz mborsz Awaiting requested review from mborsz

@lavalamp lavalamp Awaiting requested review from lavalamp

@logicalhan logicalhan Awaiting requested review from logicalhan

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@lavalamp lavalamp

@logicalhan logicalhan

@SataQiu SataQiu

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/apiserver cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

apiserver panic'd on GET /readyz
9 participants
@ialidzhikov @k8s-ci-robot @logicalhan @liggitt @wojtek-t @lavalamp @vpnachev @SataQiu @timebertt