-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating EndpointSlice controller to wait for all caches to be synced #94086
Updating EndpointSlice controller to wait for all caches to be synced #94086
Conversation
Previously the EndpointSlice controller was not waiting for EndpointSlices or Nodes to be synced.
thanks, did you sweep all the controllers involved in endpointslices to make sure they waited for caches correctly? |
/lgtm required to avoid endpointslice churn on startup. this should be picked to all releases where the controller was enabled |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@liggitt thanks for checking! I did confirm that both Endpoints and EndpointSliceMirroring controllers are waiting for the appropriate caches. For the record, EndpointSliceMirroring waits for endpoints, endpointslices, and services. Endpoints waits for pods, services, and endpoints. |
…86-upstream-release-1.18 Automated cherry pick of #94086: Updating EndpointSlice controller to wait for all caches to
…86-upstream-release-1.17 Automated cherry pick of #94086: Updating EndpointSlice controller to wait for all caches to
What type of PR is this?
/kind bug
What this PR does / why we need it:
Previously the EndpointSlice controller was not waiting for EndpointSlices or Nodes to be synced.
Special notes for your reviewer:
As identified by @liggitt in #93496 (comment)
Does this PR introduce a user-facing change?:
/sig network
/priority critical-urgent
/cc @freehan @liggitt