Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubeadm: remove the "alpha kubelet config enable-dynamic" command #94668

Merged
merged 2 commits into from
Sep 16, 2020
Merged

kubeadm: remove the "alpha kubelet config enable-dynamic" command #94668

merged 2 commits into from
Sep 16, 2020

Conversation

neolit123
Copy link
Member

@neolit123 neolit123 commented Sep 9, 2020 •
edited
Loading

What this PR does / why we need it:

The command was deprecated in 1.19 and can be removed in 1.20:
#92881

Which issue(s) this PR fixes:

Fixes kubernetes/kubeadm#2216

Special notes for your reviewer:
second commit removes a stray "kubeadm alpha phase" command which we used for experimental phases before "kubeadm init phase".

Does this PR introduce a user-facing change?:

kubeadm: remove the deprecated "kubeadm alpha kubelet config enable-dynamic" command. To continue using the feature please defer to the guide for "Dynamic Kubelet Configuration" at k8s.io. This change also removes the parent command "kubeadm alpha kubelet" as there are no more sub-commands under it for the time being.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Sep 9, 2020
@neolit123
Copy link
Member Author

/kind cleanup deprecation
/priority important-soon
/milestone v1.20

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Sep 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Sep 9, 2020
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. area/kubeadm sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 9, 2020
neolit123
neolit123 commented Sep 9, 2020
View reviewed changes
cmd/kubeadm/app/cmd/alpha/kubelet.go
)

// newCmdKubeletUtility returns command for `kubeadm phase kubelet`
func newCmdKubeletUtility() *cobra.Command {
Copy link
Member Author

@neolit123 neolit123 Sep 9, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first commit technically removes the whole kubelet.go file, because there are no more commands under kubelet -> config after enable-dynamic is removed.

@neolit123 neolit123 mentioned this pull request Sep 9, 2020
Closed
2 tasks
@neolit123
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2020
@neolit123 neolit123 force-pushed the 1.20-kubeadm-remove-dkc branch from 1cad00e to 16fded8 Compare September 11, 2020 00:39
@neolit123
kubeadm: remove the "alpha kubelet config enable-dynamic" command
a5a29c5 
The command was deprecated in 1.19 and can be removed in 1.20.
@neolit123
kubeadm: remove stray "alpha phase" command
daef96c 
This command had a TODO to be removed once kubeadm init phases are
added. Remove the command as init phases are in place already.
@neolit123
Copy link
Member Author

@fabriziopandini updated to remove cmd/kubeadm/app/phases/kubelet/dynamic*.go

@neolit123 neolit123 force-pushed the 1.20-kubeadm-remove-dkc branch from 16fded8 to daef96c Compare September 11, 2020 00:40
@fabriziopandini
Copy link
Member

/approve
lgtm pending squash

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, neolit123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@neolit123
Copy link
Member Author

neolit123 commented Sep 12, 2020 •
edited
Loading

@fabriziopandini i intentionally left the "alpha phase" cleanup in a separate commit. Lmk if you still would preffer 1 commit here.

@fabriziopandini
Copy link
Member

fine for me!
feel free to remove hold
leaving the final lgtm to @rosti or someone else

yagonobre
yagonobre reviewed Sep 14, 2020
View reviewed changes
Copy link
Member

@yagonobre yagonobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2020
@neolit123
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3ba1411 into kubernetes:master Sep 16, 2020
@github-actions github-actions bot mentioned this pull request Sep 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yagonobre yagonobre yagonobre left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

Assignees

@yagonobre yagonobre

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubeadm cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

deprecate and remove the experimental DynamicKubeletConfiguration support
4 participants
@neolit123 @fabriziopandini @k8s-ci-robot @yagonobre